From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, avarab@gmail.com, gitster@pobox.com
Subject: Re: [PATCH 2/2] grep.c: teach 'git grep --only-matching'
Date: Thu, 28 Jun 2018 14:32:31 -0400 [thread overview]
Message-ID: <20180628183231.GA12657@sigill.intra.peff.net> (raw)
In-Reply-To: <f156bd7c897359926ec407e805ecb0630a8b12da.1529961706.git.me@ttaylorr.com>
On Mon, Jun 25, 2018 at 04:26:00PM -0500, Taylor Blau wrote:
> For instance, a line containing the following (taken from README.md:27):
>
> (`man gitcvs-migration` or `git help cvs-migration` if git is
>
> Is printed as follows:
>
> $ git grep -no -e git -- README.md | grep ":27"
> README.md:27:7:git
> README.md:27:16:git
> README.md:27:38:git
This is with "--column", too, right?
> Like GNU grep, this patch ignores --only-matching when --invert (-v) is
> given. There is a sensible answer here, but parity with the behavior of
> other tools is preferred.
Yeah, after all of our discussion about inverted matching and columns,
I'm sure we could come up with _some_ answer. But I agree that what you
have here is quite sensible, and matching GNU grep seems like a good
idea.
> ---
> builtin/grep.c | 6 ++++++
> grep.c | 48 +++++++++++++++++++++++++++++++++---------------
> grep.h | 1 +
> t/t7810-grep.sh | 15 +++++++++++++++
> 4 files changed, 55 insertions(+), 15 deletions(-)
The patch itself looks pretty straightforward to me (especially with
"-w"). I didn't hit the compiler warning that Junio did (I have gcc
7.3.0). But I agree it's better to avoid even passing an uninitialized
variable to another function.
-Peff
next prev parent reply other threads:[~2018-06-28 18:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 21:25 [PATCH 0/2] grep.c: teach --only-matching to 'git-grep(1)' Taylor Blau
2018-06-25 21:25 ` [PATCH 1/2] grep.c: extract show_line_header() Taylor Blau
2018-06-25 21:26 ` [PATCH 2/2] grep.c: teach 'git grep --only-matching' Taylor Blau
2018-06-27 16:40 ` Junio C Hamano
2018-06-27 17:16 ` Taylor Blau
2018-06-27 21:11 ` Junio C Hamano
2018-06-27 21:22 ` Taylor Blau
2018-06-28 18:32 ` Jeff King [this message]
2018-07-02 20:08 ` [PATCH v2 0/2] teach --only-matching to 'git-grep(1)' Taylor Blau
2018-07-02 20:08 ` [PATCH v2 1/2] grep.c: extract show_line_header() Taylor Blau
2018-07-02 20:09 ` [PATCH v2 2/2] grep.c: teach 'git grep --only-matching' Taylor Blau
2018-07-03 14:37 ` [PATCH v2 0/2] teach --only-matching to 'git-grep(1)' Jeff King
2018-07-03 14:38 ` Jeff King
2018-07-03 20:48 ` Junio C Hamano
2018-07-03 21:51 ` [PATCH v3 0/2] grep.c: " Taylor Blau
2018-07-03 21:51 ` [PATCH v3 1/2] grep.c: extract show_line_header() Taylor Blau
2018-07-03 21:52 ` [PATCH v3 2/2] grep.c: teach 'git grep --only-matching' Taylor Blau
2018-07-04 14:53 ` [PATCH v2] " Taylor Blau
2018-07-04 14:55 ` Taylor Blau
2018-07-06 18:17 ` Junio C Hamano
2018-07-05 14:21 ` [PATCH v3 0/2] grep.c: teach --only-matching to 'git-grep(1)' Jeff King
2018-07-05 14:34 ` Taylor Blau
2018-07-06 18:21 ` Junio C Hamano
2018-07-06 20:15 ` Taylor Blau
2018-07-06 20:33 ` Jeff King
2018-07-06 21:44 ` Junio C Hamano
2018-07-09 20:33 ` [PATCH v4] grep.c: teach 'git grep --only-matching' Taylor Blau
2018-07-09 20:36 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628183231.GA12657@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).