From: Jonathan Tan <jonathantanmy@google.com>
To: bmwill@google.com
Cc: jonathantanmy@google.com, git@vger.kernel.org,
jrnieder@gmail.com, gitster@pobox.com
Subject: Re: [PATCH v2] fetch-pack: support negotiation tip whitelist
Date: Thu, 28 Jun 2018 09:12:16 -0700 [thread overview]
Message-ID: <20180628161216.68872-1-jonathantanmy@google.com> (raw)
In-Reply-To: <20180628155630.GL19910@google.com>
> This seems like a pretty difficult to use feature, requiring that I
> provide the actual OIDs. I think a much better UI would probably be to
> accept a number of different things ranging from exact OIDs to actual
> ref names or even better, allowing for ref-patterns which include globs.
> That way I can do the following:
>
> git fetch --negotiation-tip=refs/remotes/my-remote/* my-remote
>
> in order to easily limit the tips to all the refs I have from that
> particular remote.
Actual ref names are already supported - it uses the same DWIM as
others. As for globs, I thought of supporting both DWIM objects and the
LHS of refspecs, but (1) it might be strange to support master and
refs/heads/* but not heads/*, and (2) I can't think of anywhere in Git
where you can provide either one - it's either SHA-1 and DWIM name, or
SHA-1 and refspec, but not all three.
next prev parent reply other threads:[~2018-06-28 16:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 19:37 [PATCH] fetch-pack: support negotiation tip whitelist Jonathan Tan
2018-06-26 17:53 ` Jonathan Nieder
2018-06-26 18:59 ` Junio C Hamano
2018-06-27 18:28 ` [PATCH v2] " Jonathan Tan
2018-06-28 15:56 ` Brandon Williams
2018-06-28 16:12 ` Jonathan Tan [this message]
2018-06-28 16:16 ` Brandon Williams
2018-06-28 22:15 ` [PATCH v3] " Jonathan Tan
2018-06-28 22:20 ` Brandon Williams
2018-06-29 16:28 ` Junio C Hamano
2018-07-02 22:39 ` [PATCH v4] " Jonathan Tan
2018-07-22 9:09 ` Duy Nguyen
2019-06-18 13:36 ` Ævar Arnfjörð Bjarmason
2019-06-18 17:30 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628161216.68872-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).