From: Alban Gruin <alban.gruin@gmail.com>
To: git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>,
Christian Couder <christian.couder@gmail.com>,
Pratik Karki <predatoramigo@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
phillip.wood@dunelm.org.uk, Alban Gruin <alban.gruin@gmail.com>
Subject: [GSoC][PATCH 1/1] sequencer: print an error message if append_todo_help() fails
Date: Tue, 26 Jun 2018 12:04:29 +0200 [thread overview]
Message-ID: <20180626100429.10169-2-alban.gruin@gmail.com> (raw)
In-Reply-To: <20180626100429.10169-1-alban.gruin@gmail.com>
This adds an error when append_todo_help() fails to write its message to
the todo file.
Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
---
sequencer.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sequencer.c b/sequencer.c
index 7cc76332e..7c4bdbb99 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -4380,6 +4380,9 @@ int append_todo_help(unsigned edit_todo, unsigned keep_empty)
}
ret = fputs(buf.buf, todo);
+ if (ret)
+ error_errno(_("Could not append help text to '%s'"), rebase_path_todo());
+
fclose(todo);
strbuf_release(&buf);
--
2.18.0
next prev parent reply other threads:[~2018-06-26 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 10:04 [GSoC][PATCH 0/1] sequencer: print an error message if append_todo_help() fails Alban Gruin
2018-06-26 10:04 ` Alban Gruin [this message]
2018-06-26 12:57 ` [GSoC][PATCH 1/1] " Johannes Schindelin
2018-06-26 19:53 ` Junio C Hamano
2018-06-26 21:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626100429.10169-2-alban.gruin@gmail.com \
--to=alban.gruin@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=predatoramigo@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).