From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [BUG] url schemes should be case-insensitive
Date: Sun, 24 Jun 2018 04:56:23 -0400 [thread overview]
Message-ID: <20180624085622.GA28575@sigill.intra.peff.net> (raw)
We seem to match url schemes case-sensitively:
$ git clone SSH://example.com/repo.git
Cloning into 'repo'...
fatal: Unable to find remote helper for 'SSH'
whereas rfc3986 is clear that the scheme portion is case-insensitive.
We probably ought to match at least our internal ones with strcasecmp.
Possibly we should also normalize external helpers (so "FOO://bar" would
always call git-remote-foo, never git-remote-FOO).
We could probably also give an advise() message in the above output,
suggesting that the problem is likely one of:
1. They misspelled the scheme.
2. They need to install the appropriate helper.
This may be a good topic for somebody looking for low-hanging fruit to
get involved in development (I'd maybe call it a #leftoverbits, but
since I didn't start on it, I'm not sure if it counts as "left over" ;)).
-Peff
next reply other threads:[~2018-06-24 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 8:56 Jeff King [this message]
2018-06-25 18:19 ` [BUG] url schemes should be case-insensitive Junio C Hamano
2018-06-26 12:21 ` Jeff King
2018-06-26 17:09 ` Junio C Hamano
2018-06-26 18:27 ` Jeff King
2018-06-26 20:03 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180624085622.GA28575@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).