From: Christian Couder <email@example.com> To: firstname.lastname@example.org Cc: Junio C Hamano <email@example.com>, Jeff King <firstname.lastname@example.org>, Ben Peart <Ben.Peart@microsoft.com>, Jonathan Tan <email@example.com>, Nguyen Thai Ngoc Duy <firstname.lastname@example.org>, Mike Hommey <email@example.com>, Lars Schneider <firstname.lastname@example.org>, Eric Wong <email@example.com>, Christian Couder <firstname.lastname@example.org>, Jeff Hostetler <email@example.com> Subject: [PATCH v1 0/9] Introducing remote ODBs Date: Sat, 23 Jun 2018 14:18:37 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) This is a follow up from the patch series called "odb remote" that I sent earlier this year, which was itself a follow up from the patch series called "Promisor remotes and external ODB support" that I sent earlier this year, which was itself a follow up from previous series. See the links section for more information. Following discussions of the previous patch series, the mechanism is renamed from "odb remote" to "remote odb". I hope that this will will be the last name change. As with the previous "odb remote" series, this series is only about integrating with the promisor/narrow clone work and showing that it makes it possible to use more than one promisor remote. Everything that is not necessary for that integration has been removed for now (though you can still find it in one of my branches on GitHub if you want). There is one test in patch 8/9 that shows that more than one promisor remote can now be used, but I still feel that it could be interesting to add other such tests, so I am open to ideas in this area. Changes compared to previous patch series ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - big rename from "odb remote" to "remote odb" - rename of field from "dealer" to "remote" in struct odb_helper - add comments around struct odb_helper - improve a few commit messages - add a documentation patch High level overview of this patch series ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - Patch 1/9: This makes functions in fetch-object.c return an error code, which is necessary to later tell that they failed and try another remote odb when there is more than one. This could also just be seen as a fix to these functions. - Patch 2/9: This introduces the minimum infrastructure for remote odbs. - Patches 3/9 and 4/9: These patches implement remote_odb_get_direct() and remote_odb_get_many_direct() using the functions from fetch-object.c. These new functions will be used in following patches to replace the functions from fetch-object.c. - Patch 5/9: This implement remote_odb_reinit() which will be needed to reparse the remote odb configuration. - Patches 6/9 and 7/9: These patches integrate the remote odb mechanism into the promisor/narrow clone code. The "extensions.partialclone" config option is replaced by "odb.<name>.promisorRemote" and "core.partialclonefilter" is replaced by "odb.<name>.partialclonefilter". - Patch 8/9: This adds a test case that shows that now more than one promisor remote can be used. - Patch 9/9: This starts documenting the remote odb mechanism. Discussion ~~~~~~~~~~ I am not sure that it is ok to completely replace the "extensions.partialclone" config option. Even if it is fully replaced, no "extensions.remoteodb" is implemented in these patches, as maybe the "extensions.partialclone" name could be kept even if the underlying mechanism is the remote odb mechanism. Anyway I think that the remote odb mechanism is much more extensible, so I think using "extensions.partialclone" to specify a promisor remote should be at least deprecated. Links ~~~~~ This patch series on GitHub: https://github.com/chriscool/git/commits/remote-odb Previous "odb remote" series: https://email@example.com/ https://github.com/chriscool/git/commits/odb-remote Version 1 and 2 of the "Promisor remotes and external ODB support" series: https://firstname.lastname@example.org/ https://email@example.com/ Version 1 and 2 of the "Promisor remotes and external ODB support" series on GitHub: https://github.com/chriscool/git/commits/gl-small-promisor-external-odb12 https://github.com/chriscool/git/commits/gl-small-promisor-external-odb71 Christian Couder (9): fetch-object: make functions return an error code Add initial remote odb support remote-odb: implement remote_odb_get_direct() remote-odb: implement remote_odb_get_many_direct() remote-odb: add remote_odb_reinit() Use remote_odb_get_direct() and has_remote_odb() Use odb.origin.partialclonefilter instead of core.partialclonefilter t0410: test fetching from many promisor remotes Documentation/config: add odb.<name>.promisorRemote Documentation/config.txt | 5 ++ Makefile | 2 + builtin/cat-file.c | 5 +- builtin/fetch.c | 13 ++-- builtin/gc.c | 3 +- builtin/repack.c | 3 +- cache.h | 2 - connected.c | 3 +- environment.c | 1 - fetch-object.c | 15 +++-- fetch-object.h | 6 +- list-objects-filter-options.c | 49 ++++++++------ list-objects-filter-options.h | 3 +- odb-helper.c | 45 +++++++++++++ odb-helper.h | 24 +++++++ packfile.c | 3 +- remote-odb.c | 118 ++++++++++++++++++++++++++++++++++ remote-odb.h | 10 +++ setup.c | 7 +- sha1-file.c | 14 ++-- t/t0410-partial-clone.sh | 54 +++++++++++----- t/t5500-fetch-pack.sh | 4 +- t/t5601-clone.sh | 2 +- t/t5616-partial-clone.sh | 4 +- unpack-trees.c | 6 +- 25 files changed, 320 insertions(+), 81 deletions(-) create mode 100644 odb-helper.c create mode 100644 odb-helper.h create mode 100644 remote-odb.c create mode 100644 remote-odb.h -- 188.8.131.522.g886f54ea46
next reply other threads:[~2018-06-23 12:19 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-23 12:18 Christian Couder [this message] 2018-06-23 12:18 ` [PATCH v1 01/11] fetch-object: make functions return an error code Christian Couder 2018-06-23 12:18 ` [PATCH v1 02/11] Add initial remote odb support Christian Couder 2018-06-23 12:18 ` [PATCH v1 03/11] remote-odb: implement remote_odb_get_direct() Christian Couder 2018-06-23 12:18 ` [PATCH v1 04/11] remote-odb: implement remote_odb_get_many_direct() Christian Couder 2018-06-23 12:18 ` [PATCH v1 05/11] remote-odb: add remote_odb_reinit() Christian Couder 2018-06-23 12:18 ` [PATCH v1 06/11] Use remote_odb_get_direct() and has_remote_odb() Christian Couder 2018-06-23 12:18 ` [PATCH v1 07/11] Use odb.origin.partialclonefilter instead of core.partialclonefilter Christian Couder 2018-06-23 12:18 ` [PATCH v1 08/11] t0410: test fetching from many promisor remotes Christian Couder 2018-06-23 12:18 ` [PATCH v1 09/11] Documentation/config: add odb.<name>.promisorRemote Christian Couder 2018-06-23 12:29 ` [PATCH v1 0/9] Introducing remote ODBs Christian Couder 2018-06-25 21:49 ` Junio C Hamano 2018-06-26 0:37 ` Eric Sunshine 2018-06-28 15:17 ` Christian Couder 2018-06-28 13:04 ` Christian Couder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Ben.Peart@microsoft.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v1 0/9] Introducing remote ODBs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).