From: Heiko Voigt <hvoigt@hvoigt.net>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, kaartic.sivaraam@gmail.com, pclouds@gmail.com
Subject: Re: [PATCH] t5526: test recursive submodules when fetching moved submodules
Date: Thu, 14 Jun 2018 22:23:05 +0200 [thread overview]
Message-ID: <20180614202305.GB2686@book.hvoigt.net> (raw)
In-Reply-To: <20180614173730.205646-1-sbeller@google.com>
On Thu, Jun 14, 2018 at 10:37:30AM -0700, Stefan Beller wrote:
> The topic merged in 0c7ecb7c311 (Merge branch 'sb/submodule-move-nested',
> 2018-05-08) provided support for moving nested submodules.
>
> Remove the NEEDSWORK comment and implement the nested submodules test as
> the comment hinted at.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
Looks good to me.
Cheers Heiko
next prev parent reply other threads:[~2018-06-14 20:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 15:31 BUG: submodule code prints '(null)' Duy Nguyen
2018-06-06 18:32 ` Kaartic Sivaraam
2018-06-09 11:04 ` Duy Nguyen
2018-06-11 22:56 ` Stefan Beller
2018-06-14 15:15 ` Heiko Voigt
2018-06-14 15:44 ` Duy Nguyen
2018-06-14 17:31 ` [PATCH] submodule: fix NULL correctness in renamed broken submodules Stefan Beller
2018-06-14 17:37 ` [PATCH] t5526: test recursive submodules when fetching moved submodules Stefan Beller
2018-06-14 20:23 ` Heiko Voigt [this message]
2018-06-14 20:24 ` [PATCH] submodule: fix NULL correctness in renamed broken submodules Heiko Voigt
2018-06-17 14:02 ` Kaartic Sivaraam
2018-06-12 17:35 ` BUG: submodule code prints '(null)' Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614202305.GB2686@book.hvoigt.net \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).