From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] fsck: avoid looking at NULL blob->object
Date: Sat, 9 Jun 2018 05:20:56 -0400 [thread overview]
Message-ID: <20180609092056.GB6817@sigill.intra.peff.net> (raw)
In-Reply-To: <CACsJy8Cpd_0CR9F_xyQfcw0j8ceOf777KcWXLHuxY1NxmRnXqw@mail.gmail.com>
On Sat, Jun 09, 2018 at 10:45:15AM +0200, Duy Nguyen wrote:
> > It seems like we could refactor report() to just take the
> > object_id itself. But we pass the object pointer along to
> > a callback function, and indeed this ends up in
> > builtin/fsck.c's objreport() which does want to look at
> > other parts of the object (like the type).
>
> And objreport() can handle OBJ_NONE well, which is the type given by
> lookup_unknown_object(). So yeah this looks good.
Actually, we know that we have some "real" type, because otherwise
lookup_blob() would not have returned NULL. In fact, we could actually
use lookup_object() here to find that object, knowing that it exists in
the hash. But IMHO that would be depending too much on how lookup_blob()
works. :)
-Peff
next prev parent reply other threads:[~2018-06-09 9:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 8:32 [PATCH] fsck: avoid looking at NULL blob->object Jeff King
2018-06-09 8:38 ` Eric Sunshine
2018-06-09 9:19 ` Jeff King
2018-06-09 8:45 ` Duy Nguyen
2018-06-09 9:20 ` Jeff King [this message]
2018-06-09 8:50 ` Martin Ågren
2018-06-09 9:21 ` Jeff King
2018-06-09 13:44 ` Martin Ågren
2018-06-12 9:51 ` Jeff King
2018-06-09 9:30 ` [PATCH v2 0/2] .gitmodules fsck cleanups Jeff King
2018-06-09 9:31 ` [PATCH v2 1/2] t7415: don't bother creating commit for symlink test Jeff King
2018-06-09 9:46 ` SZEDER Gábor
2018-06-11 8:35 ` [PATCH v3 0/2] .gitmodules fsck cleanups Jeff King
2018-06-11 8:35 ` [PATCH v3 1/2] t7415: don't bother creating commit for symlink test Jeff King
2018-06-11 8:35 ` [PATCH v3 2/2] fsck: avoid looking at NULL blob->object Jeff King
2018-06-09 9:31 ` [PATCH v2 " Jeff King
2018-06-09 9:50 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180609092056.GB6817@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).