From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 00F3D1F403 for ; Thu, 7 Jun 2018 02:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbeFGCkw (ORCPT ); Wed, 6 Jun 2018 22:40:52 -0400 Received: from cloud.peff.net ([104.130.231.41]:37158 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753163AbeFGCkv (ORCPT ); Wed, 6 Jun 2018 22:40:51 -0400 Received: (qmail 14339 invoked by uid 109); 7 Jun 2018 02:40:51 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 07 Jun 2018 02:40:51 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 11894 invoked by uid 111); 7 Jun 2018 02:41:04 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Wed, 06 Jun 2018 22:41:04 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 06 Jun 2018 22:40:49 -0400 Date: Wed, 6 Jun 2018 22:40:49 -0400 From: Jeff King To: "brian m. carlson" , Torsten =?utf-8?Q?B=C3=B6gershausen?= , git@vger.kernel.org, =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy , =?utf-8?B?UmVuw6k=?= Scharfe Subject: Re: [PATCH 01/10] t: add tool to translate hash-related values Message-ID: <20180607024048.GC3898@sigill.intra.peff.net> References: <20180604235229.279814-1-sandals@crustytoothpaste.net> <20180604235229.279814-2-sandals@crustytoothpaste.net> <20180606061927.GA7098@tor.lan> <20180606205845.GB1381@sigill.intra.peff.net> <20180607005704.GA862596@genre.crustytoothpaste.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180607005704.GA862596@genre.crustytoothpaste.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jun 07, 2018 at 12:57:04AM +0000, brian m. carlson wrote: > > > Unless I'm wrong, we don't use the "local" keyword ? > > > > We've got a test balloon out; see 01d3a526ad (t0000: check whether the > > shell supports the "local" keyword, 2017-10-26). I think it's reasonable > > to consider starting its use. > > I used it because it's already in use earlier in the file in some of the > mingw_* functions. Perhaps we happen to know that our mingw systems > will always have a suitable /bin/sh, but I suppose some less capable > shells would still have choked on it by now. We do know in that case; it's always bash under mingw. That said... > I can remove it if necessary, but it didn't seem necessary. I feel OK about starting to use it, with the knowledge that we may get a late-comer who hasn't even tested v2.16.0 yet and says "no, wait! My shell doesn't support local!". And then we'd have to deal with it then. But I suspect that won't happen, or it will turn out that the shell in question is unusable for some other reason anyway. -Peff