From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: git@vger.kernel.org
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Jeff King" <peff@peff.net>, "René Scharfe" <l.s.r@web.de>
Subject: [PATCH 00/10] Hash-independent tests (part 3)
Date: Mon, 4 Jun 2018 23:52:19 +0000 [thread overview]
Message-ID: <20180604235229.279814-1-sandals@crustytoothpaste.net> (raw)
This is next in the series of improvements to make tests
hash-independent.
Introduced here is a test helper, test_translate, that allows lookups in
tests based on the hash algorithm in use. Alternatives are either
specified inline (the former for SHA-1, the latter for NewHash), or
(more commonly) from a file based on a key. Some basic examples of
translations are provided and used throughout the tests.
The ultimate idea is that tests can simply drop a file into the
translation directory and use their own test-specific translations if
convenient.
This series (and subsequent series) attempt to standardize slightly on
our use of invalid object IDs in tests. Since the actual invalid IDs
aren't usually very important, the translations I've made using the
tables aren't necessarily entirely faithful: we will sometimes use
different SHA-1 object IDs than before, but we substitute only invalid
object IDs for different invalid ones.
It's likely in the future that test_translate will support additional
options depending on whether we want input, output, or internal formats.
I had mentioned in a previous comment that a given test would be
included in "the next series" (this one), but I redid the series and
decided to split it into smaller pieces, so it isn't included. Sorry.
Comments on any aspect of the series are welcome, but thoughts on design
and naming would be especially valuable.
brian m. carlson (10):
t: add tool to translate hash-related values
t0000: use hash translation table
t0002: abstract away SHA-1-specific constants
t0027: use $ZERO_OID
t0064: make hash size independent
t1006: make hash size independent
t1400: switch hard-coded object ID to variable
t1405: make hash size independent
t1406: make hash-size independent
t1407: make hash size independent
t/t0000-basic.sh | 13 ++++-----
t/t0002-gitfile.sh | 26 +++++++++---------
t/t0027-auto-crlf.sh | 14 +++++-----
t/t0064-sha1-array.sh | 49 +++++++++++++++++++---------------
t/t1006-cat-file.sh | 4 +--
t/t1400-update-ref.sh | 2 +-
t/t1405-main-ref-store.sh | 4 +--
t/t1406-submodule-ref-store.sh | 6 ++---
t/t1407-worktree-ref-store.sh | 4 +--
t/test-lib-functions.sh | 40 +++++++++++++++++++++++++++
t/translate/hash-info | 9 +++++++
t/translate/oid | 15 +++++++++++
12 files changed, 129 insertions(+), 57 deletions(-)
create mode 100644 t/translate/hash-info
create mode 100644 t/translate/oid
next reply other threads:[~2018-06-04 23:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 23:52 brian m. carlson [this message]
2018-06-04 23:52 ` [PATCH 01/10] t: add tool to translate hash-related values brian m. carlson
2018-06-06 6:19 ` Torsten Bögershausen
2018-06-06 20:58 ` Jeff King
2018-06-07 0:57 ` brian m. carlson
2018-06-07 2:40 ` Jeff King
2018-06-11 7:47 ` Eric Sunshine
2018-06-12 1:05 ` brian m. carlson
2018-06-12 7:29 ` Eric Sunshine
2018-06-14 0:22 ` brian m. carlson
2018-07-24 22:17 ` brian m. carlson
2018-07-25 8:33 ` Eric Sunshine
2018-06-04 23:52 ` [PATCH 02/10] t0000: use hash translation table brian m. carlson
2018-06-04 23:52 ` [PATCH 03/10] t0002: abstract away SHA-1-specific constants brian m. carlson
2018-06-11 7:59 ` Eric Sunshine
2018-06-04 23:52 ` [PATCH 04/10] t0027: use $ZERO_OID brian m. carlson
2018-06-06 7:02 ` Torsten Bögershausen
2018-06-07 1:25 ` brian m. carlson
2018-06-04 23:52 ` [PATCH 05/10] t0064: make hash size independent brian m. carlson
2018-06-11 8:09 ` Eric Sunshine
2018-06-12 1:08 ` brian m. carlson
2018-06-04 23:52 ` [PATCH 06/10] t1006: " brian m. carlson
2018-06-04 23:52 ` [PATCH 07/10] t1400: switch hard-coded object ID to variable brian m. carlson
2018-06-04 23:52 ` [PATCH 08/10] t1405: make hash size independent brian m. carlson
2018-06-04 23:52 ` [PATCH 09/10] t1406: make hash-size independent brian m. carlson
2018-06-04 23:52 ` [PATCH 10/10] t1407: make hash size independent brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604235229.279814-1-sandals@crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).