[PATCH] completion: complete remote names too

[PATCH] completion: complete remote names too

[Łukasz Stelmach]

"git remote update" accepts both groups and single remotes.

Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 961a0ed76..fb05bb2f9 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -2632,7 +2632,7 @@ _git_remote ()
 		__gitcomp_builtin remote_update
 		;;
 	update,*)
-		__gitcomp "$(__git_get_config_variables "remotes")"
+		__gitcomp "$(__git_remotes) $(__git_get_config_variables "remotes")"
 		;;
 	set-url,--*)
 		__gitcomp_builtin remote_set-url
-- 
2.11.0

Re: [PATCH] completion: complete remote names too

[Junio C Hamano]

Łukasz Stelmach <l.stelmach@samsung.com> writes:

> "git remote update" accepts both groups and single remotes.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Soliciting comments from usual suspects around this area...

Thanks.

> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 961a0ed76..fb05bb2f9 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2632,7 +2632,7 @@ _git_remote ()
>  		__gitcomp_builtin remote_update
>  		;;
>  	update,*)
> -		__gitcomp "$(__git_get_config_variables "remotes")"
> +		__gitcomp "$(__git_remotes) $(__git_get_config_variables "remotes")"
>  		;;
>  	set-url,--*)
>  		__gitcomp_builtin remote_set-url

Re: [PATCH] completion: complete remote names too

[Duy Nguyen]

On Fri, May 25, 2018 at 12:48:42PM +0200, Łukasz Stelmach wrote:
> "git remote update" accepts both groups and single remotes.
> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 961a0ed76..fb05bb2f9 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2632,7 +2632,7 @@ _git_remote ()
>  		__gitcomp_builtin remote_update
>  		;;
>  	update,*)
> -		__gitcomp "$(__git_get_config_variables "remotes")"
> +		__gitcomp "$(__git_remotes) $(__git_get_config_variables "remotes")"

Reviewed-by: me.

The short commit description actually made me curious, which led to
more digging and finally this follow up patch.

-- 8< --
Subject: [PATCH] remote.txt: update documentation for 'update' command

Commit b344e1614b (git remote update: Fallback to remote if group does
not exist - 2009-04-06) lets "git remote update" accept individual
remotes as well. Previously this command only accepted remote
groups. The commit updates the command syntax but not the actual
document of this subcommand. Update it.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 Documentation/git-remote.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt
index 595948da53..dd38587168 100644
--- a/Documentation/git-remote.txt
+++ b/Documentation/git-remote.txt
@@ -186,8 +186,8 @@ actually prune them.
 
 'update'::
 
-Fetch updates for a named set of remotes in the repository as defined by
-remotes.<group>.  If a named group is not specified on the command line,
+Fetch updates for remotes or remote groups in the repository as defined by
+remotes.<group>.  If no group or remote is not specified on the command line,
 the configuration parameter remotes.default will be used; if
 remotes.default is not defined, all remotes which do not have the
 configuration parameter remote.<name>.skipDefaultUpdate set to true will
-- 
2.17.0.705.g3525833791

-- 8< --

Re: [PATCH] completion: complete remote names too

[Łukasz Stelmach]

[-- Attachment #1: Type: text/plain, Size: 2566 bytes --]

It was <2018-05-30 śro 17:37>, when Duy Nguyen wrote:
> On Fri, May 25, 2018 at 12:48:42PM +0200, Łukasz Stelmach wrote:
>> "git remote update" accepts both groups and single remotes.
>> 
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> ---
>>  contrib/completion/git-completion.bash | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 961a0ed76..fb05bb2f9 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -2632,7 +2632,7 @@ _git_remote ()
>>  		__gitcomp_builtin remote_update
>>  		;;
>>  	update,*)
>> -		__gitcomp "$(__git_get_config_variables "remotes")"
>> +		__gitcomp "$(__git_remotes) $(__git_get_config_variables "remotes")"
>
> Reviewed-by: me.
>
> The short commit description actually made me curious, which led to
> more digging and finally this follow up patch.
>
> -- 8< --
> Subject: [PATCH] remote.txt: update documentation for 'update' command
>
> Commit b344e1614b (git remote update: Fallback to remote if group does
> not exist - 2009-04-06) lets "git remote update" accept individual
> remotes as well. Previously this command only accepted remote
> groups. The commit updates the command syntax but not the actual
> document of this subcommand. Update it.
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  Documentation/git-remote.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-remote.txt b/Documentation/git-remote.txt
> index 595948da53..dd38587168 100644
> --- a/Documentation/git-remote.txt
> +++ b/Documentation/git-remote.txt
> @@ -186,8 +186,8 @@ actually prune them.
>  
>  'update'::
>  
> -Fetch updates for a named set of remotes in the repository as defined by
> -remotes.<group>.  If a named group is not specified on the command line,
> +Fetch updates for remotes or remote groups in the repository as defined by
> +remotes.<group>.  If no group or remote is not specified on the command line,

If neither group nor remote is specified on the command line,

>  the configuration parameter remotes.default will be used; if
>  remotes.default is not defined, all remotes which do not have the
>  configuration parameter remote.<name>.skipDefaultUpdate set to true will

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]