From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: [PATCH 2/2] sequencer.c: plug mem leak in git_sequencer_config
Date: Mon, 4 Jun 2018 00:51:22 -0400 [thread overview]
Message-ID: <20180604045122.GE14451@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqin6z5g8e.fsf@gitster-ct.c.googlers.com>
On Mon, Jun 04, 2018 at 01:26:57PM +0900, Junio C Hamano wrote:
> > Doing it "right" in C would probably involve two variables:
> >
> > const char *some_var = "default";
> > const char *some_var_storage = NULL;
> >
> > int git_config_string_smart(const char **ptr, char **storage,
> > const char *var, const char *value)
> > {
> > ...
> > free(*storage);
> > *ptr = *storage = xstrdup(value);
> > return 0;
> > }
> >
> > #define GIT_CONFIG_STRING(name, var, value) \
> > git_config_string_smart(&(name), &(name##_storage), var, value)
> >
> > Or something like that.
>
> The attitude the approach takes is that "run once and let exit(3)
> clean after us" programs *should* care.
Even with "let exit clean up", we are still leaking heap every time the
variable is assigned after the first. Again, I don't think it matters
that much in practice, but I think:
[core]
editor = foo
editor = foo
...etc...
would leak arbitrary memory during the config parse, that would be
allocated for the remainder of the program. I guess you could say exit()
is handling it, but I think the point is that we are letting exit()
handle memory that was potentially useful until we exit, not leaks. :)
> And at that point, maybe
>
> char *some_var = xstrdup("default");
> git_config_string(&some_var, ...);
>
> that takes "char **" and frees the current storage before assigning
> to it may be simpler than the two-variable approach.
That _is_ much nicer, but you cannot use xstrdup() as the initializer
for a global "static char *some_var", which is what the majority of the
config variables are. It's this "static initializer sometimes, run-time
heap sometimes" duality to the variables that makes handling it such a
pain.
With that strategy, we'd have to have a big initialize_defaults()
function. Which actually might not be _too_ bad since we now have
common-main.c, but:
- it sucks to keep the default values far away from the declarations
- it does carry a runtime cost. Not a huge one, but it sucks to pay it
on every program startup, even if we're not using those variables.
-Peff
next prev parent reply other threads:[~2018-06-04 4:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 20:01 [PATCH 1/2] sequencer.c: plug leaks in do_pick_commit Stefan Beller
2018-06-01 20:01 ` [PATCH 2/2] sequencer.c: plug mem leak in git_sequencer_config Stefan Beller
2018-06-04 2:41 ` Junio C Hamano
2018-06-04 3:44 ` Junio C Hamano
2018-06-04 3:56 ` Jeff King
2018-06-04 4:26 ` Junio C Hamano
2018-06-04 4:51 ` Jeff King [this message]
2018-06-04 4:55 ` Junio C Hamano
2018-06-21 7:03 ` Johannes Schindelin
2018-06-21 11:46 ` Jeff King
2018-06-04 5:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604045122.GE14451@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).