git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Git Mailing list" <git@vger.kernel.org>
Subject: Re: [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR
Date: Sun,  3 Jun 2018 16:29:10 +0200	[thread overview]
Message-ID: <20180603142910.6211-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1806030820180.14575@localhost.localdomain>

Could you please add "in a comment" to the end of the subject line?
So it will be immediately clear to future readers of 'git log
--oneline' that this is not a bugfix.

> Fix single misspelling of $GITDIR to correct $GIT_DIR.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
> only occurrence in entire code base that i ran across, so i figured
> might as well fix it.
> 
> diff --git a/sha1-file.c b/sha1-file.c
> index 555e780f4..695e5c627 100644
> --- a/sha1-file.c
> +++ b/sha1-file.c
> @@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)
>  /*
>   * Compute the exact path an alternate is at and returns it. In case of
>   * error NULL is returned and the human readable error is added to `err`
> - * `path` may be relative and should point to $GITDIR.
> + * `path` may be relative and should point to $GIT_DIR.
>   * `err` must not be null.
>   */
>  char *compute_alternate_path(const char *path, struct strbuf *err)

      reply	other threads:[~2018-06-03 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-03 12:22 [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR Robert P. J. Day
2018-06-03 14:29 ` SZEDER Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180603142910.6211-1-szeder.dev@gmail.com \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).