From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] fsckObjects tests: show how v2.17.1 can exploit downstream
Date: Thu, 31 May 2018 02:02:59 -0400 [thread overview]
Message-ID: <20180531060259.GE17344@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqk1rmexng.fsf@gitster-ct.c.googlers.com>
On Wed, May 30, 2018 at 10:32:19AM +0900, Junio C Hamano wrote:
> If we want to also encourage people to vet their own "fetches", I am
> not against extending documentation. It just is different from "we
> extended the mechanism to help server side protect their clients"
> that was the focus of (updated, relative to what is in the tarball)
> the description in the release notes.
I haven't tested it, but I suspect that doing multiple fetches could
result in passing bad objects through a fetch.fsckObjects filter.
Because the objects aren't quarantined on fetch, and because
fsck_finish() requires the objects to be installed into place, they may
still exist in the repository even if we end up rejecting them. Would a
subsequent fetch hit the quickfetch() code and update without actually
sending the objects again?
This problem is specific to the .gitmodules thing, I think, because the
other fsck checks are able to die much earlier (before fsck_finish).
I think in the long run fetch should implement a similar quarantine
procedure to what happens on push.
-Peff
next prev parent reply other threads:[~2018-05-31 6:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 21:19 [PATCH] fsckObjects tests: show how v2.17.1 can exploit downstream Ævar Arnfjörð Bjarmason
2018-05-29 21:24 ` Jeff King
2018-05-29 21:59 ` Ævar Arnfjörð Bjarmason
2018-05-30 2:57 ` Junio C Hamano
2018-05-31 5:54 ` Jeff King
2018-05-31 6:52 ` Ævar Arnfjörð Bjarmason
2018-05-30 1:32 ` Junio C Hamano
2018-05-31 6:02 ` Jeff King [this message]
2018-06-01 1:42 ` Junio C Hamano
2018-06-01 5:57 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531060259.GE17344@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).