git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Thomas Gummerer <t.gummerer@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	"Thomas Gummerer" <t.gummerer@gmail.com>
Subject: [PATCH v2 1/2] SubmittingPatches: replace numbered attributes with names
Date: Wed, 30 May 2018 21:52:54 +0100	[thread overview]
Message-ID: <20180530205255.13090-1-t.gummerer@gmail.com> (raw)
In-Reply-To: <20180527140433.32277-1-t.gummerer@gmail.com>

Use names instead of numbers for the AsciiDoc attributes that are used
for the footnotes.  We will add more footnotes in subsequent commits,
and attributes should ideally all be unique.  Having named attributes
will help ensure uniqueness, and we won't have to re-number the
attributes if we add a footnote earlier in the document.

In addition it also clarifies that the attribute name/number is not
related to the number the footnote will get in the output.

Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
---

Thanks Junio, Jonathan and brian for the comments on the previous
round at <20180527140433.32277-1-t.gummerer@gmail.com>.  This round
squashes the two patches I sent previously adding the mentions of the
security mailing list into one, and adds this preparatory patch.

The security mailing list is now mentioned twice in SubmittingPatches,
to make sure people don't miss it, and the wording was adjusted to
match the document better.

 Documentation/SubmittingPatches | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 945f8edb46..27553128f5 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -264,12 +264,12 @@ people who are involved in the area you are touching (the `git
 contacts` command in `contrib/contacts/` can help to
 identify them), to solicit comments and reviews.
 
-:1: footnote:[The current maintainer: gitster@pobox.com]
-:2: footnote:[The mailing list: git@vger.kernel.org]
+:current-maintainer: footnote:[The current maintainer: gitster@pobox.com]
+:git-ml: footnote:[The mailing list: git@vger.kernel.org]
 
 After the list reached a consensus that it is a good idea to apply the
-patch, re-send it with "To:" set to the maintainer{1} and "cc:" the
-list{2} for inclusion.
+patch, re-send it with "To:" set to the maintainer{current-maintainer} and "cc:" the
+list{git-ml} for inclusion.
 
 Do not forget to add trailers such as `Acked-by:`, `Reviewed-by:` and
 `Tested-by:` lines as necessary to credit people who helped your
-- 
2.17.0.1181.g093e983b0


  parent reply	other threads:[~2018-05-30 20:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-27 14:04 [PATCH] README: note git-security@googlegroups.com Thomas Gummerer
2018-05-27 15:34 ` Jonathan Nieder
2018-05-27 21:08   ` [PATCH 2/1] SubmittingPatches: not git-security@googlegroups.com Thomas Gummerer
2018-05-28  3:00     ` Junio C Hamano
2018-05-29 18:02       ` Thomas Gummerer
2018-05-29 18:05         ` Thomas Gummerer
2018-05-29 19:53         ` brian m. carlson
2018-05-30 20:52 ` Thomas Gummerer [this message]
2018-05-30 20:52   ` [PATCH v2 2/2] note git-security@googlegroups.com in more places Thomas Gummerer
2018-05-30 23:37     ` brian m. carlson
2018-05-31 19:22       ` Thomas Gummerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530205255.13090-1-t.gummerer@gmail.com \
    --to=t.gummerer@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).