git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 0/5] fsck: doc fixes & fetch.fsck.* implementation
Date: Fri, 25 May 2018 19:28:06 +0000	[thread overview]
Message-ID: <20180525192811.25680-1-avarab@gmail.com> (raw)
In-Reply-To: <20180524193516.28713-1-avarab@gmail.com>

This should address all the comments to v1. Inter-diff:
    
    1: a9cd795db5 ! 1: 3d61e44cb8 config doc: don't describe *.fetchObjects twice
        @@ -1,10 +1,6 @@
         Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
         
             config doc: don't describe *.fetchObjects twice
        -    
        -    Change the copy/pasted description of the fetch.fsckObjects and
        -    receive.fsckObjects variables to refer to transfer.fsckObjects
        -    instead.
             
             Let's not duplicate the description of what *.fsckObjects does twice.
             instead let's refer to transfer.fsckObjects from both fetch.* and
    2: 637c2d4241 ! 2: 9683fd2ec6 config doc: unify the description of fsck.* and receive.fsck.*
        @@ -64,21 +64,21 @@
         +unless someone is being deliberately malicious.
          
          fsck.skipList::
        --	The path to a sorted list of object names (i.e. one SHA-1 per
        + 	The path to a sorted list of object names (i.e. one SHA-1 per
         -	line) that are known to be broken in a non-fatal way and should
         -	be ignored. This feature is useful when an established project
         -	should be accepted despite early commits containing errors that
         -	can be safely ignored such as invalid committer email addresses.
         -	Note: corrupt objects cannot be skipped with this setting.
        -+	Like `fsck.<msg-id>` this variable has a corresponding
        -+	`receive.fsck.skipList` variant.
        ++	line) that are known to be broken in a non-fatal way and
        ++	should be ignored. This feature is useful when an established
        ++	project should be accepted despite early commits containing
        ++	errors that can be safely ignored such as invalid committer
        ++	email addresses. Note: corrupt objects cannot be skipped with
        ++	this setting.
         ++
        -+The path to a sorted list of object names (i.e. one SHA-1 per line)
        -+that are known to be broken in a non-fatal way and should be
        -+ignored. This feature is useful when an established project should be
        -+accepted despite early commits containing errors that can be safely
        -+ignored such as invalid committer email addresses. Note: corrupt
        -+objects cannot be skipped with this setting.
        ++Like `fsck.<msg-id>` this variable has a corresponding
        ++`receive.fsck.skipList` variant.
          
          gc.aggressiveDepth::
          	The depth parameter used in the delta compression
    3: 55dc555196 < -:  ------- config doc: elaborate on what transfer.fsckObjects does
    -:  ------- > 3: 8e9646a6ce config doc: elaborate on what transfer.fsckObjects does
    -:  ------- > 4: 2b3aafdfde config doc: mention future aspirations for transfer.fsckObjects
    4: 13f4d994c0 ! 5: be32b19696 fetch: implement fetch.fsck.*
        @@ -67,16 +67,16 @@
          When `fsck.<msg-id>` is set, errors can be switched to warnings and
          vice versa by configuring the `fsck.<msg-id>` setting where the
         @@
        - unless someone is being deliberately malicious.
        - 
        - fsck.skipList::
        --	Like `fsck.<msg-id>` this variable has a corresponding
        --	`receive.fsck.skipList` variant.
        -+	Like `fsck.<msg-id>` this variable has corresponding
        -+	`receive.fsck.skipList` and `fetch.fsck.skipList` variants.
        + 	email addresses. Note: corrupt objects cannot be skipped with
        + 	this setting.
          +
        - The path to a sorted list of object names (i.e. one SHA-1 per line)
        - that are known to be broken in a non-fatal way and should be
        +-Like `fsck.<msg-id>` this variable has a corresponding
        +-`receive.fsck.skipList` variant.
        ++Like `fsck.<msg-id>` this variable has corresponding
        ++`receive.fsck.skipList` and `fetch.fsck.skipList` variants.
        + 
        + gc.aggressiveDepth::
        + 	The depth parameter used in the delta compression
         
         diff --git a/fetch-pack.c b/fetch-pack.c
         --- a/fetch-pack.c

The "mention future aspirations for transfer.fsckObjects" patch is
new. I've split up the "we're probably going to quarantine fetches
too" part of this.

Ævar Arnfjörð Bjarmason (5):
  config doc: don't describe *.fetchObjects twice
  config doc: unify the description of fsck.* and receive.fsck.*
  config doc: elaborate on what transfer.fsckObjects does
  config doc: mention future aspirations for transfer.fsckObjects
  fetch: implement fetch.fsck.*

 Documentation/config.txt        | 112 ++++++++++++++++++++------------
 fetch-pack.c                    |  32 ++++++++-
 t/t5504-fetch-receive-strict.sh |  46 +++++++++++++
 3 files changed, 148 insertions(+), 42 deletions(-)

-- 
2.17.0.290.gded63e768a


  reply	other threads:[~2018-05-25 19:28 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 15:25 BUG: No way to set fsck.<msg-id> when cloning Ævar Arnfjörð Bjarmason
2018-05-24 15:58 ` Kevin Daudt
2018-05-24 17:04   ` Ævar Arnfjörð Bjarmason
2018-05-24 19:02     ` Jeff King
2018-05-24 19:35       ` [PATCH 0/4] fsck: doc fixes & fetch.fsck.* implementation Ævar Arnfjörð Bjarmason
2018-05-25 19:28         ` Ævar Arnfjörð Bjarmason [this message]
2018-07-27 14:37           ` [PATCH v3 00/10] " Ævar Arnfjörð Bjarmason
2018-07-30 22:13             ` SZEDER Gábor
2018-07-27 14:37           ` [PATCH v3 01/10] receive.fsck.<msg-id> tests: remove dead code Ævar Arnfjörð Bjarmason
2018-07-27 19:11             ` Junio C Hamano
2018-07-27 19:45               ` Ævar Arnfjörð Bjarmason
2018-07-27 22:19                 ` Junio C Hamano
2018-07-27 14:37           ` [PATCH v3 02/10] config doc: don't describe *.fetchObjects twice Ævar Arnfjörð Bjarmason
2018-07-27 19:19             ` Junio C Hamano
2018-07-27 14:37           ` [PATCH v3 03/10] config doc: unify the description of fsck.* and receive.fsck.* Ævar Arnfjörð Bjarmason
2018-07-27 19:29             ` Junio C Hamano
2018-07-27 14:37           ` [PATCH v3 04/10] config doc: elaborate on what transfer.fsckObjects does Ævar Arnfjörð Bjarmason
2018-07-27 19:41             ` Junio C Hamano
2018-07-27 14:37           ` [PATCH v3 05/10] config doc: elaborate on fetch.fsckObjects security Ævar Arnfjörð Bjarmason
2018-07-27 19:45             ` Junio C Hamano
2018-07-28 14:09               ` Ævar Arnfjörð Bjarmason
2018-07-27 14:37           ` [PATCH v3 06/10] transfer.fsckObjects tests: untangle confusing setup Ævar Arnfjörð Bjarmason
2018-07-27 14:37           ` [PATCH v3 07/10] fetch: implement fetch.fsck.* Ævar Arnfjörð Bjarmason
2018-07-27 20:18             ` Junio C Hamano
2018-07-27 21:08             ` Junio C Hamano
2018-07-30 14:58             ` Duy Nguyen
2018-07-30 15:06               ` Ævar Arnfjörð Bjarmason
2018-07-27 14:37           ` [PATCH v3 08/10] fsck: test & document {fetch,receive}.fsck.* config fallback Ævar Arnfjörð Bjarmason
2018-07-27 21:28             ` Junio C Hamano
2018-07-27 14:37           ` [PATCH v3 09/10] fsck: add stress tests for fsck.skipList Ævar Arnfjörð Bjarmason
2018-07-27 14:37           ` [PATCH v3 10/10] fsck: test and document unknown fsck.<msg-id> values Ævar Arnfjörð Bjarmason
2018-07-27 19:50             ` Ævar Arnfjörð Bjarmason
2018-07-27 21:43             ` Junio C Hamano
2018-07-28 13:55               ` Ævar Arnfjörð Bjarmason
2018-07-30 14:47                 ` Junio C Hamano
2018-05-25 19:28         ` [PATCH v2 1/5] config doc: don't describe *.fetchObjects twice Ævar Arnfjörð Bjarmason
2018-05-25 21:07           ` Eric Sunshine
2018-05-25 19:28         ` [PATCH v2 2/5] config doc: unify the description of fsck.* and receive.fsck.* Ævar Arnfjörð Bjarmason
2018-05-25 21:16           ` Eric Sunshine
2018-05-28  9:45             ` Junio C Hamano
2018-05-28 16:44               ` Ævar Arnfjörð Bjarmason
2018-05-30  3:05                 ` Junio C Hamano
2018-05-30  3:39                   ` Junio C Hamano
2018-05-31  7:20                   ` Ævar Arnfjörð Bjarmason
2018-06-01  0:11                     ` Junio C Hamano
2018-05-25 19:28         ` [PATCH v2 3/5] config doc: elaborate on what transfer.fsckObjects does Ævar Arnfjörð Bjarmason
2018-05-25 21:19           ` Eric Sunshine
2018-05-25 19:28         ` [PATCH v2 4/5] config doc: mention future aspirations for transfer.fsckObjects Ævar Arnfjörð Bjarmason
2018-05-25 20:33           ` Christian Couder
2018-05-25 19:28         ` [PATCH v2 5/5] fetch: implement fetch.fsck.* Ævar Arnfjörð Bjarmason
2018-05-30  3:47           ` Junio C Hamano
2018-05-31  7:23             ` Ævar Arnfjörð Bjarmason
2018-05-28  9:48         ` [PATCH 0/4] fsck: doc fixes & fetch.fsck.* implementation Junio C Hamano
2018-05-24 19:35       ` [PATCH 1/4] config doc: don't describe *.fetchObjects twice Ævar Arnfjörð Bjarmason
2018-05-25  3:18         ` Junio C Hamano
2018-05-24 19:35       ` [PATCH 2/4] config doc: unify the description of fsck.* and receive.fsck.* Ævar Arnfjörð Bjarmason
2018-05-24 19:53         ` Eric Sunshine
2018-05-24 20:12           ` Ævar Arnfjörð Bjarmason
2018-05-24 22:49             ` Eric Sunshine
2018-05-25  2:07               ` Junio C Hamano
2018-05-24 19:35       ` [PATCH 3/4] config doc: elaborate on what transfer.fsckObjects does Ævar Arnfjörð Bjarmason
2018-05-24 20:15         ` Eric Sunshine
2018-05-25  3:22           ` Junio C Hamano
2018-05-31  7:32             ` Ævar Arnfjörð Bjarmason
2018-05-24 19:35       ` [PATCH 4/4] fetch: implement fetch.fsck.* Ævar Arnfjörð Bjarmason
2018-05-25  4:09         ` Junio C Hamano
2018-05-24 17:04 ` BUG: No way to set fsck.<msg-id> when cloning Jeff King
2018-05-24 20:48 ` Thomas Braun
2018-05-25  7:36   ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180525192811.25680-1-avarab@gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).