From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Ben Peart <peartben@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Johannes Sixt" <j6t@kdbg.org>,
"Stefan Beller" <sbeller@google.com>
Subject: Re: [PATCH v4 00/28] Hash-independent tests
Date: Mon, 21 May 2018 23:08:45 +0000 [thread overview]
Message-ID: <20180521230845.GG652292@genre.crustytoothpaste.net> (raw)
In-Reply-To: <63adc6e2-19c6-72c9-1c56-47503e128231@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
On Mon, May 21, 2018 at 09:17:39AM -0400, Ben Peart wrote:
> Do you plan to update those tests that hard code the SHA of the index file
> itself? For example, t1700-split-index.sh has hard coded values for the SHA
> and currently only supports different hard coded values for V4 indexes vs
> others.
I have some additional test changes that use the SHA1 prerequisite,
plus some that fix issues due to the use of a different hash algorithm
or a longer hash algorithm.
Ultimately, I plan to discard the SHA1 prerequisite and update those
tests to use a translation table to look up the correct values depending
on the hash algorithm in use. However, we haven't decided on the actual
algorithm that NewHash will be yet, so I can't write those translation
tables at this point.
I plan to start a discussion about the choice of algorithm soon, since
we'll soon need to make a decision in order to progress, but I need to
do some research and testing in order to have sufficient facts to
present to the list.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]
prev parent reply other threads:[~2018-05-21 23:08 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 1:56 [PATCH v3 00/28] Hash-independent tests brian m. carlson
2018-05-16 1:56 ` [PATCH v3 01/28] t/test-lib: add an SHA1 prerequisite brian m. carlson
2018-05-16 1:56 ` [PATCH v3 02/28] t/test-lib: introduce ZERO_OID brian m. carlson
2018-05-16 1:56 ` [PATCH v3 03/28] t: switch $_z40 to $ZERO_OID brian m. carlson
2018-05-16 1:56 ` [PATCH v3 04/28] t/test-lib: introduce OID_REGEX brian m. carlson
2018-05-16 1:56 ` [PATCH v3 05/28] t: switch $_x40 to $OID_REGEX brian m. carlson
2018-05-16 1:56 ` [PATCH v3 06/28] t0000: annotate with SHA1 prerequisite brian m. carlson
2018-05-16 1:56 ` [PATCH v3 07/28] t1007: " brian m. carlson
2018-05-16 16:56 ` Stefan Beller
2018-05-16 23:10 ` brian m. carlson
2018-05-16 1:56 ` [PATCH v3 08/28] t1512: skip test if not using SHA-1 brian m. carlson
2018-05-16 1:56 ` [PATCH v3 09/28] t4044: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 10/28] t: skip pack tests " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 11/28] t2203: abstract away SHA-1-specific constants brian m. carlson
2018-05-16 1:56 ` [PATCH v3 12/28] t3103: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 13/28] t3702: " brian m. carlson
2018-05-16 17:18 ` Stefan Beller
2018-05-16 23:46 ` brian m. carlson
2018-05-16 1:56 ` [PATCH v3 14/28] t3905: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 15/28] t4007: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 16/28] t4008: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 17/28] t4014: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 18/28] t4020: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 19/28] t4022: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 20/28] t4029: fix test indentation brian m. carlson
2018-05-16 1:56 ` [PATCH v3 21/28] t4029: abstract away SHA-1-specific constants brian m. carlson
2018-05-16 1:56 ` [PATCH v3 22/28] t4030: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 23/28] t/lib-diff-alternative: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 24/28] t4205: sort log output in a hash-independent way brian m. carlson
2018-05-16 1:56 ` [PATCH v3 25/28] t4042: abstract away SHA-1-specific constants brian m. carlson
2018-05-16 1:56 ` [PATCH v3 26/28] t4045: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 27/28] t4208: " brian m. carlson
2018-05-16 1:56 ` [PATCH v3 28/28] t5300: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 00/28] Hash-independent tests brian m. carlson
2018-05-21 2:01 ` [PATCH v4 01/28] t/test-lib: add an SHA1 prerequisite brian m. carlson
2018-05-21 2:01 ` [PATCH v4 02/28] t/test-lib: introduce ZERO_OID brian m. carlson
2018-05-21 2:01 ` [PATCH v4 03/28] t: switch $_z40 to $ZERO_OID brian m. carlson
2018-05-21 2:01 ` [PATCH v4 04/28] t/test-lib: introduce OID_REGEX brian m. carlson
2018-05-21 2:01 ` [PATCH v4 05/28] t: switch $_x40 to $OID_REGEX brian m. carlson
2018-05-21 2:01 ` [PATCH v4 06/28] t0000: annotate with SHA1 prerequisite brian m. carlson
2018-05-21 2:01 ` [PATCH v4 07/28] t1007: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 08/28] t1512: skip test if not using SHA-1 brian m. carlson
2018-05-21 2:01 ` [PATCH v4 09/28] t4044: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 10/28] t: skip pack tests " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 11/28] t2203: abstract away SHA-1-specific constants brian m. carlson
2018-05-21 2:01 ` [PATCH v4 12/28] t3103: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 13/28] t3702: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 14/28] t3905: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 15/28] t4007: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 16/28] t4008: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 17/28] t4014: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 18/28] t4020: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 19/28] t4022: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 20/28] t4029: fix test indentation brian m. carlson
2018-05-21 2:01 ` [PATCH v4 21/28] t4029: abstract away SHA-1-specific constants brian m. carlson
2018-05-21 2:01 ` [PATCH v4 22/28] t4030: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 23/28] t/lib-diff-alternative: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 24/28] t4205: sort log output in a hash-independent way brian m. carlson
2018-05-21 2:01 ` [PATCH v4 25/28] t4042: abstract away SHA-1-specific constants brian m. carlson
2018-05-21 2:01 ` [PATCH v4 26/28] t4045: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 27/28] t4208: " brian m. carlson
2018-05-21 2:01 ` [PATCH v4 28/28] t5300: " brian m. carlson
2018-05-21 13:17 ` [PATCH v4 00/28] Hash-independent tests Ben Peart
2018-05-21 23:08 ` brian m. carlson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521230845.GG652292@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=martin.agren@gmail.com \
--cc=pclouds@gmail.com \
--cc=peartben@gmail.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).