From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C19DA1F406 for ; Thu, 10 May 2018 16:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966469AbeEJQEK (ORCPT ); Thu, 10 May 2018 12:04:10 -0400 Received: from cloud.peff.net ([104.130.231.41]:35048 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S966422AbeEJQEJ (ORCPT ); Thu, 10 May 2018 12:04:09 -0400 Received: (qmail 9087 invoked by uid 109); 10 May 2018 16:04:09 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 10 May 2018 16:04:09 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 25948 invoked by uid 111); 10 May 2018 16:04:13 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Thu, 10 May 2018 12:04:13 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 10 May 2018 12:04:07 -0400 Date: Thu, 10 May 2018 12:04:07 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , "brian m . carlson" , Derrick Stolee , Stefan Beller , Eric Sunshine , Duy Nguyen Subject: Re: [PATCH v4 0/6] get_short_oid UI improvements Message-ID: <20180510160407.GD6462@sigill.intra.peff.net> References: <20180501184016.15061-10-avarab@gmail.com> <20180510124303.6020-1-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180510124303.6020-1-avarab@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, May 10, 2018 at 12:42:57PM +0000, Ævar Arnfjörð Bjarmason wrote: > This is like v3 except all the patches to the peel syntax & docs have > been dropped, which were controversial. > > I think it's worthwhile to re-work that, but I don't have time for > that now, so I'm submitting this. Maybe I'll have time in the future > to re-work the rest, but then I can base it on top of this. I'm not quite on-board with the final patch, but with the exception of a few nits I sent already, the first 5 look good to me. -Peff