From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] replace-object.c: remove the_repository from prepare_replace_object
Date: Thu, 10 May 2018 07:56:23 -0400 [thread overview]
Message-ID: <20180510115623.GA20632@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqtvrfizce.fsf@gitster-ct.c.googlers.com>
On Thu, May 10, 2018 at 07:23:13PM +0900, Junio C Hamano wrote:
> This one was doing
>
> ptr = xmalloc(sizeof(*another_ptr))
>
> and it was OK because ptr and another_ptr happened to be of the same
> type. I wonder if we are making it safer, or making it more obscure
> to seasoned C programmers, if we introduced a pair of helper macros,
> perhaps like these:
>
> #define ALLOCATE(ptr) (ptr) = xmalloc(sizeof(*(ptr)))
> #define CALLOCATE(ptr,cnt) (ptr) = xcalloc((cnt), sizeof(*(ptr)))
I've often wondered that, too. It's the natural endgame of the
ALLOC_ARRAY() road we've been going down.
-Peff
next prev parent reply other threads:[~2018-05-10 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 23:40 [PATCH 1/2] object.c: free replace map in raw_object_store_clear Stefan Beller
2018-05-09 23:40 ` [PATCH 2/2] replace-object.c: remove the_repository from prepare_replace_object Stefan Beller
2018-05-10 10:23 ` Junio C Hamano
2018-05-10 11:56 ` Jeff King [this message]
2018-05-10 14:53 ` Derrick Stolee
2018-05-10 18:32 ` Stefan Beller
2018-05-10 10:16 ` [PATCH 1/2] object.c: free replace map in raw_object_store_clear Junio C Hamano
2018-05-10 17:23 ` Stefan Beller
-- strict thread matches above, loose matches on Subject: below --
2018-05-17 18:20 What's cooking in git.git (May 2018, #02; Thu, 17) Stefan Beller
2018-05-17 18:29 ` [PATCH 0/2] Reroll 2 last commits of sb/object-store-replace Stefan Beller
2018-05-17 18:29 ` [PATCH 2/2] replace-object.c: remove the_repository from prepare_replace_object Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510115623.GA20632@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).