From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 9838B200B9 for ; Sat, 5 May 2018 18:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751818AbeEES30 (ORCPT ); Sat, 5 May 2018 14:29:26 -0400 Received: from cloud.peff.net ([104.130.231.41]:57236 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751235AbeEES3Z (ORCPT ); Sat, 5 May 2018 14:29:25 -0400 Received: (qmail 13032 invoked by uid 109); 5 May 2018 18:29:24 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Sat, 05 May 2018 18:29:24 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12170 invoked by uid 111); 5 May 2018 18:29:27 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Sat, 05 May 2018 14:29:27 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Sat, 05 May 2018 14:29:22 -0400 Date: Sat, 5 May 2018 14:29:22 -0400 From: Jeff King To: Johannes Schindelin Cc: git@vger.kernel.org, Junio C Hamano , Thomas Rast , Thomas Gummerer , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Ramsay Jones , Stefan Beller , Jacob Keller , Eric Sunshine Subject: Re: [PATCH v2 13/18] color: provide inverted colors, too Message-ID: <20180505182922.GD17700@sigill.intra.peff.net> References: <1ebbe359547689d32aa27564929d733a26bb8054.1525448066.git.johannes.schindelin@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1ebbe359547689d32aa27564929d733a26bb8054.1525448066.git.johannes.schindelin@gmx.de> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, May 04, 2018 at 05:34:58PM +0200, Johannes Schindelin wrote: > For every regular color, there exists the inverted equivalent where > background and foreground colors are exchanged. > > We will use this in the next commit to allow inverting *just* the +/- > signs in a diff. There's a "reverse" attribute (which we already parse and support) that can do this without having to repeat the colors. AFAIK it's well supported everywhere, but I could be wrong. I wonder if that would make configuring this slightly more pleasant, since it saves the user having to define "oldinv" whenever they change "old". -Peff