From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C872C200B9 for ; Fri, 4 May 2018 13:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751114AbeEDN1J (ORCPT ); Fri, 4 May 2018 09:27:09 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59046 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750820AbeEDN1J (ORCPT ); Fri, 4 May 2018 09:27:09 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8977E406C745; Fri, 4 May 2018 13:27:08 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F603111DCFD; Fri, 4 May 2018 13:27:00 +0000 (UTC) Date: Fri, 4 May 2018 15:26:58 +0200 From: Cornelia Huck To: Eric Blake Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, berrange@redhat.com, kwolf@redhat.com, peter.maydell@linaro.org, Christian Borntraeger , Alexander Graf , qemu-s390x@nongnu.org, git@vger.kernel.org Subject: Re: cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers] Message-ID: <20180504152658.3537707a.cohuck@redhat.com> In-Reply-To: References: <1525376963-79623-1-git-send-email-mst@redhat.com> <1525376963-79623-61-git-send-email-mst@redhat.com> <20180504091007.55405a6a.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 04 May 2018 13:27:08 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Fri, 04 May 2018 13:27:08 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, 4 May 2018 08:07:53 -0500 Eric Blake wrote: > [adding a cross-post to the git mailing list] > > On 05/04/2018 02:10 AM, Cornelia Huck wrote: > > On Thu, 3 May 2018 22:51:40 +0300 > > "Michael S. Tsirkin" wrote: > > > >> This way they are easier to find using standard rules. > >> > >> Signed-off-by: Michael S. Tsirkin > >> --- > ... > > > [Goes to find cover letter to figure out what this is all about. > > *Please*, cc: people on the cover letter so they can see immediately > > what this is trying to do!] > > Is there an EASY way to make 'git format-patch --cover-letter $commitid' > (and git send-email, by extension) automatically search for all cc's any > any of the N/M patches, and auto-cc ALL of those recipients on the 0/N > cover letter? And if that is not something easily built into git > format-patch directly, is it something that can easily be added to > sendemail.cccmd? This is not the first time that someone has complained > that automatic cc's are not sending the cover letter context to a > particular maintainer interested (and auto-cc'd) in only a subset of an > overall series. I think for most cases where I've been cc:ed on the cover letter and only some of the patches, people actually added cc: lines to the cover letter manually. > > On the other hand, cc'ing all recipients for a largely mechanical patch > series that was split into 67 parts, in part because it touches so many > different maintainers' areas, may make the cover letter have so many > recipients that various mail gateways start rejecting it as potential spam. Yes, large cross-subsystem patch series make this painful. If I get some patches like "subsystem: frobnicate foo" and it's clear that it's simply frobnicating foo for various subsystems, I can see what this is about without reading the cover letter, no need to cc: me. In this case, however, the patch did not make any sense at all without looking at the explanation in the cover letter. So I think we don't want to do this automatically, although some way to collect potential candidates for cc:ing on the cover letter might be helpful.