From: Cornelia Huck <cohuck@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, berrange@redhat.com, kwolf@redhat.com,
peter.maydell@linaro.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
qemu-s390x@nongnu.org, git@vger.kernel.org
Subject: Re: cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers]
Date: Fri, 4 May 2018 15:26:58 +0200 [thread overview]
Message-ID: <20180504152658.3537707a.cohuck@redhat.com> (raw)
In-Reply-To: <be79d6dd-beaa-ba6f-2990-b5e91139411b@redhat.com>
On Fri, 4 May 2018 08:07:53 -0500
Eric Blake <eblake@redhat.com> wrote:
> [adding a cross-post to the git mailing list]
>
> On 05/04/2018 02:10 AM, Cornelia Huck wrote:
> > On Thu, 3 May 2018 22:51:40 +0300
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> >> This way they are easier to find using standard rules.
> >>
> >> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >> ---
> ...
>
> > [Goes to find cover letter to figure out what this is all about.
> > *Please*, cc: people on the cover letter so they can see immediately
> > what this is trying to do!]
>
> Is there an EASY way to make 'git format-patch --cover-letter $commitid'
> (and git send-email, by extension) automatically search for all cc's any
> any of the N/M patches, and auto-cc ALL of those recipients on the 0/N
> cover letter? And if that is not something easily built into git
> format-patch directly, is it something that can easily be added to
> sendemail.cccmd? This is not the first time that someone has complained
> that automatic cc's are not sending the cover letter context to a
> particular maintainer interested (and auto-cc'd) in only a subset of an
> overall series.
I think for most cases where I've been cc:ed on the cover letter and
only some of the patches, people actually added cc: lines to the cover
letter manually.
>
> On the other hand, cc'ing all recipients for a largely mechanical patch
> series that was split into 67 parts, in part because it touches so many
> different maintainers' areas, may make the cover letter have so many
> recipients that various mail gateways start rejecting it as potential spam.
Yes, large cross-subsystem patch series make this painful.
If I get some patches like "subsystem: frobnicate foo" and it's clear
that it's simply frobnicating foo for various subsystems, I can see
what this is about without reading the cover letter, no need to cc: me.
In this case, however, the patch did not make any sense at all without
looking at the explanation in the cover letter.
So I think we don't want to do this automatically, although some way to
collect potential candidates for cc:ing on the cover letter might be
helpful.
next prev parent reply other threads:[~2018-05-04 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1525376963-79623-1-git-send-email-mst@redhat.com>
[not found] ` <1525376963-79623-61-git-send-email-mst@redhat.com>
[not found] ` <20180504091007.55405a6a.cohuck@redhat.com>
2018-05-04 13:07 ` cover letter cc's [was: [PATCH 60/67] hw/s390x: add include directory headers] Eric Blake
2018-05-04 13:26 ` Cornelia Huck [this message]
2018-05-04 13:32 ` Peter Maydell
2018-05-04 21:38 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504152658.3537707a.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=eblake@redhat.com \
--cc=git@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).