From: "Eckhard Maaß" <eckhard.s.maass@googlemail.com>
To: Matthieu Moy <git@matthieu-moy.fr>
Cc: "Eckhard Maaß" <eckhard.s.maass@googlemail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Elijah Newren" <newren@gmail.com>,
"Ben Peart" <peartben@gmail.com>
Subject: Re: [PATCH v2] wt-status: use rename settings from init_diff_ui_defaults
Date: Tue, 1 May 2018 18:09:11 +0200 [thread overview]
Message-ID: <20180501160911.GA14477@esm> (raw)
In-Reply-To: <1652522802.213664.1525177431907.JavaMail.zimbra@matthieu-moy.fr>
On Tue, May 01, 2018 at 02:23:51PM +0200, Matthieu Moy wrote:
> I'm fine with it as-is. Before your "fix", the config was ignored
> because overwritten by init_diff_ui_defaults() after reading the
> config, so effect of your change is indeed what the commit message
> describes.
>
> I'm often thinking aloud while reviewing, don't take my comments as
> objections.
No worries, I was wondering while writing the patch to extract it - the
init should be changed to the appropriate location even if there is
consensus to leave all the other knobs as they are, shouldn't it?
Greetings,
Eckhard
prev parent reply other threads:[~2018-05-01 16:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c466854f-6087-e7f1-264a-1d2df9fd9b5a@gmail.com>
2018-05-01 9:49 ` [PATCH v2] wt-status: use rename settings from init_diff_ui_defaults Eckhard S. Maaß
2018-05-01 11:00 ` Ævar Arnfjörð Bjarmason
2018-05-01 11:37 ` Eckhard Maaß
[not found] ` <50c60ddfeb9a44a99f556be2c2ca9a34@BPMBX2013-01.univ-lyon1.fr>
2018-05-01 11:09 ` Matthieu Moy
2018-05-01 11:43 ` Eckhard Maaß
2018-05-01 12:23 ` Matthieu Moy
2018-05-01 15:52 ` Elijah Newren
2018-05-01 23:11 ` Junio C Hamano
2018-05-02 0:08 ` Elijah Newren
2018-05-02 14:20 ` Ben Peart
2018-05-03 5:22 ` Eckhard Maaß
2018-05-04 11:12 ` [PATCH v3] wt-status: use settings from git_diff_ui_config Eckhard S. Maaß
2018-05-04 15:13 ` Elijah Newren
2018-05-01 16:09 ` Eckhard Maaß [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501160911.GA14477@esm \
--to=eckhard.s.maass@googlemail.com \
--cc=git@matthieu-moy.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).