git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Eckhard S. Maaß" <eckhard.s.maass@googlemail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Matthieu Moy" <Matthieu.Moy@imag.fr>,
	"Jeff King" <peff@peff.net>,
	"Eckhard S. Maaß" <eckhard.s.maass@gmail.com>
Subject: [PATCH 0/1] Use the diff.rename configuration for git status
Date: Mon, 30 Apr 2018 11:34:20 +0200	[thread overview]
Message-ID: <20180430093421.27551-1-eckhard.s.maass@gmail.com> (raw)

Hello,

I have been irritated that the output of git status does not adhere to
the same diff settings than the other commands like git show. I think it
is more of an oversight and git status is also intended to show the same
kind of rename detection (without any more options passed a long the
command line) than other similar commands do. This patch should fix that
issue.

I am aware that this change would also change how the porcelain
variations of git status behave for rename detection. However, I could
not find any hints that the rename detection should be fixed. As the
default would not change (50% rename threshold), this still seems
reasonable to me.

As for documentation, I am unsure what and where to add: for me it seems
like git status should already behave that way, but it is a change and
so far none else seemed to have brought it up.

Greetings,
Eckhard

Eckhard S. Maaß (1):
  wt-status: use rename settings from init_diff_ui_defaults

 builtin/commit.c       |  2 +-
 t/t4001-diff-rename.sh | 12 ++++++++++++
 wt-status.c            |  4 ----
 3 files changed, 13 insertions(+), 5 deletions(-)

-- 
2.17.0.252.gfe0a9eaf31


             reply	other threads:[~2018-04-30  9:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  9:34 Eckhard S. Maaß [this message]
2018-04-30  9:34 ` [PATCH 1/1] wt-status: use rename settings from init_diff_ui_defaults Eckhard S. Maaß
2018-04-30 19:27   ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180430093421.27551-1-eckhard.s.maass@gmail.com \
    --to=eckhard.s.maass@googlemail.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=eckhard.s.maass@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).