From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, l.s.r@web.de, peff@peff.net
Subject: [PATCH 0/6] Teach '--column-number' to 'git-grep(1)'
Date: Fri, 20 Apr 2018 20:45:26 -0700 [thread overview]
Message-ID: <20180421034526.GA24606@syl.local> (raw)
Hi,
Attached is a series to add --column-number to 'git-grep(1)', and
support jumping to the correct column when using Peff's 'git-jump'.
I have chosen -m as the short form of --column-number, because -c was
taken, and -m is close to -n (the short form of --line-number).
The description in each patch is extensive, and can serve as a reference
during review. Thank you in advance for your time, and--as always--I
look forward to your feedback :-).
Thanks,
Taylor
Taylor Blau (6):
grep.c: take regmatch_t as argument in match_line()
grep.c: take column number as argument to show_line()
grep.[ch]: teach columnnum, color_columnno to grep_opt
grep.c: display column number of first match
builtin/grep.c: show column numbers via --column-number
contrib/git-jump/git-jump: use column number when grep-ing
Documentation/config.txt | 5 +++++
Documentation/git-grep.txt | 9 ++++++++-
builtin/grep.c | 1 +
contrib/git-jump/git-jump | 2 +-
grep.c | 33 ++++++++++++++++++++++++---------
grep.h | 2 ++
t/t7810-grep.sh | 22 ++++++++++++++++++++++
7 files changed, 63 insertions(+), 11 deletions(-)
--
2.17.0
reply other threads:[~2018-04-21 3:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180421034526.GA24606@syl.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).