From: Kim Gybels <kgybels@infogroep.be>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>, Oleg Gubanov <oleg.gubanov@gmail.com>
Subject: Re: [PATCH 2/2] daemon: graceful shutdown of client connection
Date: Sun, 15 Apr 2018 22:21:22 +0200 [thread overview]
Message-ID: <20180415202122.GA4657@infogroep.be> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1804131440100.65@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
On (13/04/18 15:03), Johannes Schindelin wrote:
> I wonder whether you found a reliable way to trigger this? It would be
> nice to have a regression test for this.
On my system, it reproduced reliably using Oleg's example [1], below is my bash
version of it.
Script to generate repository with some history:
$ cat example.sh
#!/bin/bash
git init example
cd example
git --help > foo.txt
for i in $(seq 1 12); do
cat foo.txt foo.txt > bar.txt
mv bar.txt foo.txt
git add foo.txt
git commit -m v$i
done
$ ./example.sh
Initialized empty Git repository in C:/git/bug/example/.git/
[master (root-commit) 2e44b4a] v1
1 file changed, 84 insertions(+)
create mode 100644 foo.txt
[master 9791332] v2
1 file changed, 84 insertions(+)
[master 524e672] v3
1 file changed, 168 insertions(+)
[master afec6ef] v4
1 file changed, 336 insertions(+)
[master 1bcd9cc] v5
1 file changed, 672 insertions(+)
[master 2f38a8e] v6
1 file changed, 1344 insertions(+)
[master 33382fe] v7
1 file changed, 2688 insertions(+)
[master 6c2cbd6] v8
1 file changed, 5376 insertions(+)
[master 8d0770f] v9
1 file changed, 10752 insertions(+)
[master 517d650] v10
1 file changed, 21504 insertions(+)
[master 9e12406] v11
1 file changed, 43008 insertions(+)
[master 4c4f600] v12
1 file changed, 86016 insertions(+)
Server side:
$ git daemon --verbose --reuseaddr --base-path=$(pwd) --export-all
[4760] Ready to rumble
[696] Connection from 127.0.0.1:2054
[696] unable to set SO_KEEPALIVE on socket: No such file or directory
[696] Extended attribute "host": 127.0.0.1
[696] Request upload-pack for '/example'
Client side:
$ git clone git://127.0.0.1/example
Cloning into 'example'...
remote: Counting objects: 36, done.
remote: Compressing objects: 100% (24/24), done.
fatal: read error: Invalid argument
fatal: early EOF
fatal: index-pack failed
System information:
$ git --version --build-options
git version 2.17.0.windows.1
cpu: x86_64
built from commit: e7621d891d081acff6acd1f0ba6ae0adce06dd09
sizeof-long: 4
$ cmd.exe /c ver
Microsoft Windows [Version 10.0.16299.371]
Best regards,
Kim
[1] https://github.com/git-for-windows/git/issues/304#issuecomment-274266897
next prev parent reply other threads:[~2018-04-15 20:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 21:07 [PATCH 0/2] Fix early EOF with GfW daemon Kim Gybels
2018-04-12 21:07 ` [PATCH 1/2] daemon: use timeout for uninterruptible poll Kim Gybels
2018-04-13 12:36 ` Johannes Schindelin
2018-04-15 17:08 ` Kim Gybels
2018-04-18 21:16 ` Johannes Schindelin
2018-04-15 21:54 ` Junio C Hamano
2018-04-15 22:16 ` Junio C Hamano
2018-04-18 21:07 ` Johannes Schindelin
2018-04-18 21:51 ` Junio C Hamano
2018-04-19 21:33 ` Kim Gybels
2018-04-19 23:18 ` Junio C Hamano
2018-04-12 21:07 ` [PATCH 2/2] daemon: graceful shutdown of client connection Kim Gybels
2018-04-13 13:03 ` Johannes Schindelin
2018-04-15 20:21 ` Kim Gybels [this message]
2018-04-18 21:48 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180415202122.GA4657@infogroep.be \
--to=kgybels@infogroep.be \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=oleg.gubanov@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).