* [PATCH] configure.ac: fix botched FREAD_READS_DIRECTORIES check
@ 2018-04-09 8:50 Eric Sunshine
0 siblings, 0 replies; only message in thread
From: Eric Sunshine @ 2018-04-09 8:50 UTC (permalink / raw)
To: git; +Cc: Jeff King, Jonathan Primrose, Eric Sunshine
3adf9fdecf (configure.ac: loosen FREAD_READS_DIRECTORIES test program,
2017-06-14) broke the test program for the FREAD_READS_DIRECTORIES check
by making it syntactically invalid (a dangling ")") and by botching the
type returned from 'main' (a FILE* rather than int). As a consequence,
the test program won't even compile, thus the check fails
unconditionally. Fix these problems.
Reported-by: Jonathan Primrose <jprimros@gmail.com>
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
---
Problem report and discussion:
https://public-inbox.org/git/82c91eac-9dc4-834b-4648-3c4ba45af80d@gmail.com/
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 7f8415140f..a30d947e2a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -923,7 +923,7 @@ AC_RUN_IFELSE(
[AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],
[[
FILE *f = fopen(".", "r");
- return f)]])],
+ return f != NULL;]])],
[ac_cv_fread_reads_directories=no],
[ac_cv_fread_reads_directories=yes])
])
--
2.17.0.484.g0c8726318c
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-09 8:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 8:50 [PATCH] configure.ac: fix botched FREAD_READS_DIRECTORIES check Eric Sunshine
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).