From: Jeff King <peff@peff.net>
To: Olaf Hering <olaf@aepfle.de>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: How to undo previously set configuration?
Date: Fri, 6 Apr 2018 12:15:07 -0400 [thread overview]
Message-ID: <20180406161506.GA28093@sigill.intra.peff.net> (raw)
In-Reply-To: <20180406175556.5b6e16f0.olaf@aepfle.de>
On Fri, Apr 06, 2018 at 05:55:56PM +0200, Olaf Hering wrote:
> > The general strategy in Git's config is that instead of "unsetting",
> > you
> > should overwrite with whatever value you _do_ want. So a config option
> > like sendemail.smtpauth should accept some kind of empty or "none" value
> > to disable auth.
> >
> > Most single-value config options should work this way (and if one
> > doesn't, I'd say that's a bug we should fix).
>
> This does not work. Initially I copied the global config into the repo
> and set all unwanted values to <empty>, like 'smtpuser='. Perhaps the
> config parser recognized that fact, but the consumer does not?
Yes. That logic is handled by the consumer (especially in the case of
send-email, which is a perl script, the code runs in a totally separate
process from the config parser). Naively I'd think that:
[sendemail]
smtpAuth =
would do what you want, and then we'd ignore smtpUser completely.
It looks like the smtp_auth_maybe function uses perl's "defined" there,
though. Perhaps it should treat the empty string the same there.
(Or maybe it's something else; I don't use send-email myself, and in a
few trivial examples I couldn't get it to complain about similar
config).
-Peff
next prev parent reply other threads:[~2018-04-06 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 7:23 How to configure sendemail for no-auth? Olaf Hering
2018-04-05 8:42 ` How to undo previously set configuration? Ævar Arnfjörð Bjarmason
2018-04-05 8:49 ` Olaf Hering
2018-04-05 11:21 ` Ævar Arnfjörð Bjarmason
2018-04-05 12:03 ` Randall S. Becker
2018-04-05 13:25 ` Olaf Hering
2018-04-05 16:32 ` Jeff King
2018-04-06 15:55 ` Olaf Hering
2018-04-06 16:15 ` Jeff King [this message]
2018-04-06 16:57 ` Rafael Ascensao
2018-04-06 17:50 ` Jeff King
2018-04-05 10:24 ` How to configure sendemail for no-auth? astian
2018-04-05 10:27 ` astian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406161506.GA28093@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).