From: Jeff King <peff@peff.net>
To: "Jens Krüger" <Jens.Krueger@frm2.tum.de>
Cc: Git List <git@vger.kernel.org>
Subject: Re: Test 5561 failed
Date: Tue, 3 Apr 2018 09:14:48 -0400 [thread overview]
Message-ID: <20180403131447.GB18824@sigill.intra.peff.net> (raw)
In-Reply-To: <66ac8aec-3e4c-43be-83d1-7bd823ec2b20@frm2.tum.de>
On Tue, Apr 03, 2018 at 01:43:37PM +0200, Jens Krüger wrote:
> expecting success:
> GET refs/heads/master "404 Not Found"
>
> not ok 2 - direct refs/heads/master not found
That GET function is:
GET() {
curl --include "$HTTPD_URL/$SMART/repo.git/$1" >out 2>/dev/null &&
tr '\015' Q <out |
sed '
s/Q$//
1q
' >act &&
echo "HTTP/1.1 $2" >exp &&
test_cmp exp act
}
The tarball you sent shows "out" as empty, and "act" is missing. So
"curl" produced no output, and we did not make it as far as the tr/sed
pipe. Just a guess, but are you missing the "curl" command-line tool on
your system? If so, "apt install curl" should fix the failure.
As far as code changes in Git, perhaps (assuming my guess is right):
- drop the redirect of stderr here; the test suite already handles
hiding stderr from the user (without "-v"), and in "-v" mode you
probably would have gotten a useful error like "curl: not found"
- it's rare but possible to have libcurl installed (which is needed
for the server side, and what we key on for running the httpd tests)
but not the curl binary. This test probably should check for the
existence of the curl binary as a prerequisite.
-Peff
next prev parent reply other threads:[~2018-04-03 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 11:43 Test 5561 failed Jens Krüger
2018-04-03 13:14 ` Jeff King [this message]
2018-04-03 13:29 ` Jens Krüger
2018-04-03 14:00 ` [PATCH 0/2] t5561 fails without curl installed Jeff King
2018-04-03 14:01 ` [PATCH 1/2] t5561: drop curl stderr redirects Jeff King
2018-04-03 14:01 ` [PATCH 2/2] t5561: skip tests if curl is not available Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403131447.GB18824@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Jens.Krueger@frm2.tum.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).