From: Jeff King <peff@peff.net>
To: "Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)"
<brady@cisco.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] credential: cred helper fast exit can cause SIGPIPE, crash
Date: Thu, 29 Mar 2018 13:55:01 -0400 [thread overview]
Message-ID: <20180329175501.GE31833@sigill.intra.peff.net> (raw)
In-Reply-To: <330BFBFA-6B9E-456D-A9B3-2D0EF5383A57@cisco.com>
On Thu, Mar 29, 2018 at 05:25:04PM +0000, Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco) wrote:
> OK, will retry on the comment. I guess I misunderstood the guidelines
> a bit on the signoff as well (ie: non-optional), apologies. Will
> resubmit via 'git send-email' after adjusting the comment and
> recommitting with the -s option. First time for everything I suppose,
> doh.
The signoff (for our project) is all about the "yes, this contribution
can go under the gpl". So that part is very non-optional. :)
> As to your comment suggestion, appreciated, looks good. I might
> reword the #1 item you have just a bit (I removed the host specific
> stuff since I think the race can occur regardless of host specific or
> not... but I might be missing something there?). Anyhow, how about
> something like this:
Yeah, it can definitely occur regardless. It was just the plausible
reason to have a handler which does not bother to look at the incoming
data (since otherwise you are spewing your password to any host you
connect to; maybe that's OK if you configure it only inside a specific
repo and only fetch from one server).
Your update looks fine to me.
Thanks.
-Peff
next prev parent reply other threads:[~2018-03-29 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 22:20 [PATCH] credential: cred helper fast exit can cause SIGPIPE, crash Erik E Brady
2018-03-29 11:19 ` Jeff King
2018-03-29 17:25 ` Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)
2018-03-29 17:55 ` Jeff King [this message]
2018-03-29 18:00 ` [PATCH] credential: ignore SIGPIPE when writing to credential helpers Erik E Brady
2018-03-29 21:51 ` Jeff King
2018-03-29 22:20 ` Erik Brady -X (brady - ROBERT HALF INTERNATIONAL INC at Cisco)
2018-03-29 22:29 ` Jeff King
2018-03-29 22:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329175501.GE31833@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=brady@cisco.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).