From: Jonathan Nieder <jrnieder@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Alexandre Julliard" <julliard@winehq.org>,
"Dorab Patel" <dorabpatel@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"David Kågedal" <davidk@lysator.liu.se>,
"Kyle Meyer" <kyle@kyleam.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Ami Fischman" <fischman@google.com>
Subject: Re: [PATCH v3] git{,-blame}.el: remove old bitrotting Emacs code
Date: Tue, 27 Mar 2018 09:57:51 -0700 [thread overview]
Message-ID: <20180327165751.GA4343@aiede.svl.corp.google.com> (raw)
In-Reply-To: <20180310184545.16950-1-avarab@gmail.com>
Hi,
Ævar Arnfjörð Bjarmason wrote[1]:
> The git-blame.el mode has been superseded by Emacs's own
> vc-annotate (invoked by C-x v g). Users of the git.el mode are now
> much better off using either Magit or the Git backend for Emacs's own
> VC mode.
>
> These modes were added over 10 years ago when Emacs's own Git support
> was much less mature, and there weren't other mature modes in the wild
> or shipped with Emacs itself.
>
> These days these modes have few if any users, and users of git aren't
> well served by us shipping these (some OS's install them alongside git
> by default, which is confusing and leads users astray).
>
> So let's remove these per Alexandre Julliard's message to the
> ML[1]. If someone still wants these for some reason they're better
> served by hosting these elsewhere (e.g. on ELPA), instead of us
> distributing them with git.
The trouble with removing these so abruptly is that it makes for a bad
user experience.
Warning (initialization): An error occurred while loading ‘/home/jrn/.emacs’:
File error: Cannot open load file, No such file or directory, git
In some sense that is the distributor's fault: just because Git
upstream stops removing the git.el file doesn't mean that the
distributor needs to. But the same thing would happen if the user
symlinked git.el into a place that emacs could find when using
upstream Git directly. And we are putting the distributor in a bad
place.
Ami Fischman (cc-ed) writes:
| IMO a placeholder git.el that did something like:
|
| (error "git.el is no more; replace (require 'git) with (require 'magit) or
| simply delete the former in your initialization file(s)")
|
| ideally with a pointer to a short URL explaining the rationale would have
| been fine.
| (note that though I've seen
| https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=893734 I'm _still_ unclear
| as to why the change was made; you might want to clarify in that bug and
| point to it from this, or something else)
What do you think? Would adding such a placeholder during a
transitional period work well for you?
Thanks,
Jonathan
[1] https://public-inbox.org/git/20180310184545.16950-1-avarab@gmail.com/
next prev parent reply other threads:[~2018-03-27 16:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EKzyQbDEJGG4Lm5YboF8xg@mail.gmail.com>
2018-03-10 18:45 ` [PATCH v3] git{,-blame}.el: remove old bitrotting Emacs code Ævar Arnfjörð Bjarmason
2018-03-13 18:53 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2018-03-13 22:14 ` Junio C Hamano
2018-03-27 16:57 ` Jonathan Nieder [this message]
2018-04-11 20:42 ` [PATCH v4] " Ævar Arnfjörð Bjarmason
2018-04-12 2:19 ` Junio C Hamano
2018-04-12 6:52 ` Ævar Arnfjörð Bjarmason
2018-04-12 9:23 ` Junio C Hamano
2018-04-18 20:16 ` Todd Zullinger
2018-03-03 3:48 [PATCH] git.el: handle default excludesfile properly Dorab Patel
2018-03-03 8:42 ` Eric Sunshine
2018-03-04 1:36 ` Dorab Patel
2018-03-04 2:12 ` Eric Sunshine
2018-03-04 2:57 ` Dorab Patel
2018-03-04 4:34 ` Eric Sunshine
2018-03-05 2:36 ` Junio C Hamano
2018-03-06 11:54 ` Alexandre Julliard
2018-03-07 21:52 ` Dorab Patel
2018-03-08 9:41 ` Ævar Arnfjörð Bjarmason
2018-03-08 9:45 ` [PATCH] git{,-blame}.el: remove old bitrotting Emacs code Ævar Arnfjörð Bjarmason
2018-03-08 17:27 ` Junio C Hamano
2018-03-10 12:30 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2018-03-10 16:50 ` Martin Ågren
2018-03-13 18:40 ` Junio C Hamano
2018-03-08 17:55 ` [PATCH] " Kyle Meyer
2018-03-06 4:38 ` [PATCH v2] git.el: handle default excludesfile properly Dorab Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327165751.GA4343@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=davidk@lysator.liu.se \
--cc=dorabpatel@gmail.com \
--cc=fischman@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=julliard@winehq.org \
--cc=kyle@kyleam.com \
--cc=martin.agren@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).