From: Eric Wong <e@80x24.org>
To: Andreas Heiduk <asheiduk@gmail.com>
Cc: git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v2 2/2] git-svn: allow empty email-address in authors-prog and authors-file
Date: Tue, 20 Mar 2018 22:07:43 +0000 [thread overview]
Message-ID: <20180320220743.GA17234@whir> (raw)
In-Reply-To: <b3fce9b7-9fc7-c5a6-eaa5-a5c12ef7d492@gmail.com>
Andreas Heiduk <asheiduk@gmail.com> wrote:
> Am 19.03.2018 um 00:04 schrieb Eric Wong:
> > Andreas Heiduk <asheiduk@gmail.com> wrote:
> >> The email address in --authors-file and --authors-prog can be empty but
> >> git-svn translated it into a syntethic email address in the form
> >> $USERNAME@$REPO_UUID. Now git-svn behaves like git-commit: If the email
> >> is explicitly set to the empty string, the commit does not contain
> >> an email address.
> >
> > What is missing is WHY "<>" is preferable to "<$USERNAME@$REPO_UUID>".
> >
> > $USERNAME is good anyways since projects/organizations tie their
> > SVN usernames to email usernames via LDAP, making it easy to
> > infer their email address from $USERNAME. The latter can also
> > be used to disambiguate authors if they happen to have the same
> > real name.
>
> That's still available and it's even still the default.
OK.
> But: If the user of git-svn takes the burden of writing an authors
> script or maintaining an authors file then he should have full control
> over the result as long as git can handle the output reasonably.
> Currently that's the case for git but not for git-svn.
Fair enough.
> jondoe <>
>
> just means: "There is intentionally no email address." For an
> internal, ephemeral repository that can be OK. It has the advantage,
> that no automatic system (Jira, Jenkins, ...) will try to send emails to
>
> jondoe <jondoe@6aafaa21e0fb4338a68ab372a049893d>
OK, that's a good reason to allow "<>" and should be in the
commit message.
> Further steps: Eric Sunshine mentioned [1] that you might have concerns about
> the change of behavior per se. For me the patch is not so much a new feature but
> a bugfix bringing git-svn in sync with git itself. Adding an option parameter
> to enable the new behavior seems strange to me. But there might be other ways
> to achieve the same effect:
New options are not desirable, either, as they increase
testing/maintenance overhead. So I'm inclined to take your
patch with only an updated commit message...
No rush, though; will wait another bit for others to comment and
I expect to be preoccupied this week with other projects and
weather problems on the forecast :<
next prev parent reply other threads:[~2018-03-20 22:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180304112237.19254-1-asheiduk@gmail.co>
2018-03-11 13:58 ` [PATCH v2 0/2] git-svn: --author-prog improvements Andreas Heiduk
2018-03-18 21:19 ` Andreas Heiduk
2018-03-18 21:31 ` Eric Sunshine
2018-03-11 13:58 ` [PATCH v2 1/2] git-svn: search --authors-prog in PATH too Andreas Heiduk
2018-03-11 13:58 ` [PATCH v2 2/2] git-svn: allow empty email-address in authors-prog and authors-file Andreas Heiduk
2018-03-18 23:04 ` Eric Wong
2018-03-19 22:48 ` Andreas Heiduk
2018-03-20 22:07 ` Eric Wong [this message]
2018-03-24 10:20 ` [PATCH v3] git-svn: allow empty email-address using " Andreas Heiduk
2018-04-05 7:51 ` Eric Wong
2018-04-05 18:23 ` Andreas Heiduk
2018-04-05 19:44 ` Eric Wong
2018-04-11 23:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320220743.GA17234@whir \
--to=e@80x24.org \
--cc=asheiduk@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).