From: Jeff King <email@example.com> To: Dakota Hawkins <firstname.lastname@example.org> Cc: "Junio C Hamano" <email@example.com>, Git <firstname.lastname@example.org>, "Nguyễn Thái Ngọc Duy" <email@example.com> Subject: Re: .gitattributes override behavior (possible bug, or documentation bug) Date: Tue, 20 Mar 2018 00:40:36 -0400 [thread overview] Message-ID: <20180320044036.GD13302@sigill.intra.peff.net> (raw) In-Reply-To: <CAHnyXxQMbnNam=oB_B57xDZBaMPRn_8hfKtostHPV6nBHbTBog@mail.gmail.com> On Tue, Mar 20, 2018 at 12:25:27AM -0400, Dakota Hawkins wrote: > > Right. The technical reason is mostly "that is not how it was designed, > > and it would possibly break some corner cases if we switched it now". > > I'm just spitballing here, but do you guys think there's any subset of > the combined .gitignore and .gitattributes matching functionality that > could at least serve as a good "best-practices, going forward" > (because of consistency) for both? I will say every time I do this for > a new repo and have to do something even slightly complicated or > different from what I've done before with .gitattributes/.gitignore > that it takes me a long-ish time to figure it out. It's like I'm > vaguely aware of pitfalls I've encountered in the past in certain > areas but don't remember exactly what they are, so I consult the docs, > which are (in sum) confusing and lead to more time spent > trying/failing/trying/works/fails-later/etc. > > One "this subset of rules will work for both this way" would be > awesome even if the matching capabilities are technically divergent, > but on the other hand that might paint both into a corner in terms of > functionality. As far as I know, they should be the same with the exception of this recursion, and the negative-pattern thing. But I'm cc-ing Duy, who is the resident expert on ignore and attributes matching (whether he wants to be or not ;) ). I wouldn't be surprised if there's something I don't know about. So I think the "recommended subset" is basically "everything but these few constructs". We just need to document them. ;) I probably should cc'd Duy on the documentation patch, too: https://public-inbox.org/git/20180320041454.GA15213@sigill.intra.peff.net/ -Peff
next prev parent reply other threads:[~2018-03-20 4:40 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-20 1:49 Dakota Hawkins 2018-03-20 2:34 ` Jeff King 2018-03-20 3:10 ` Dakota Hawkins 2018-03-20 3:17 ` Dakota Hawkins 2018-03-20 4:12 ` Jeff King 2018-03-20 4:04 ` Jeff King 2018-03-20 4:14 ` [PATCH] doc/gitattributes: mention non-recursive behavior Jeff King 2018-03-20 4:28 ` Dakota Hawkins 2018-03-20 16:41 ` Duy Nguyen 2018-03-21 6:50 ` Jeff King 2018-03-21 16:16 ` Duy Nguyen 2018-03-23 9:12 ` Jeff King 2018-03-20 4:25 ` .gitattributes override behavior (possible bug, or documentation bug) Dakota Hawkins 2018-03-20 4:40 ` Jeff King [this message] 2018-03-20 4:49 ` Dakota Hawkins 2018-03-20 16:28 ` Duy Nguyen 2018-03-21 3:22 ` Dakota Hawkins 2018-03-21 6:52 ` Jeff King 2018-03-21 7:36 ` Dakota Hawkins 2018-03-21 7:44 ` Dakota Hawkins 2018-03-21 7:50 ` Jeff King 2018-03-21 8:35 ` Dakota Hawkins 2018-03-21 8:36 ` Jeff King 2018-03-21 16:18 ` Junio C Hamano 2018-03-21 16:07 ` Duy Nguyen 2018-03-20 3:33 ` Junio C Hamano 2018-03-20 3:40 ` Dakota Hawkins 2018-03-20 3:45 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180320044036.GD13302@sigill.intra.peff.net \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: .gitattributes override behavior (possible bug, or documentation bug)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).