* [PATCH] Documentation/githooks: Clarify the behavior of post-checkout hook
@ 2018-03-13 19:59 Magne Land
2018-03-14 0:38 ` Jonathan Nieder
0 siblings, 1 reply; 2+ messages in thread
From: Magne Land @ 2018-03-13 19:59 UTC (permalink / raw)
To: git
From: Magne Land <magne.land@appfolio.com>
This can happen when using 'git rebase -i’:
could not detach HEAD
Based on discovering this Stack Overflow discussion:
https://stackoverflow.com/questions/25561485/git-rebase-i-with-squash-cannot-detach-head
---
Documentation/githooks.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
index f877f7b7cd19c..3a4e027d0d175 100644
--- a/Documentation/githooks.txt
+++ b/Documentation/githooks.txt
@@ -166,7 +166,9 @@ worktree. The hook is given three parameters: the ref of the previous HEAD,
the ref of the new HEAD (which may or may not have changed), and a flag
indicating whether the checkout was a branch checkout (changing branches,
flag=1) or a file checkout (retrieving a file from the index, flag=0).
-This hook cannot affect the outcome of 'git checkout'.
+
+If this hook exits with a non-zero status, 'git checkout' will exit with the
+same status.
It is also run after 'git clone', unless the --no-checkout (-n) option is
used. The first parameter given to the hook is the null-ref, the second the
--
https://github.com/git/git/pull/470
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation/githooks: Clarify the behavior of post-checkout hook
2018-03-13 19:59 [PATCH] Documentation/githooks: Clarify the behavior of post-checkout hook Magne Land
@ 2018-03-14 0:38 ` Jonathan Nieder
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Nieder @ 2018-03-14 0:38 UTC (permalink / raw)
To: Magne Land; +Cc: git
Hi,
Magne Land wrote:
> From: Magne Land <magne.land@appfolio.com>
>
> This can happen when using 'git rebase -i’:
> could not detach HEAD
>
> Based on discovering this Stack Overflow discussion:
> https://stackoverflow.com/questions/25561485/git-rebase-i-with-squash-cannot-detach-head
> ---
> Documentation/githooks.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thanks for investigating and writing this.
May we forge your sign-off? See Documentation/SubmittingPatches
section [[sign-off] 'Certify your work' for more about what this
means.
The above leaves one question unanswered: is this the *right* behavior
for "git checkout" to have? I.e. is it useful for "git checkout" to
fail when the post-checkout hook fails, or would it be better for it
to e.g. simply print a message and exit with status 0?
Not a rhetorical question: I'm asking because I don't know the answer.
What do you think?
Thanks,
Jonathan
> --- a/Documentation/githooks.txt
> +++ b/Documentation/githooks.txt
> @@ -166,7 +166,9 @@ worktree. The hook is given three parameters: the ref of the previous HEAD,
> the ref of the new HEAD (which may or may not have changed), and a flag
> indicating whether the checkout was a branch checkout (changing branches,
> flag=1) or a file checkout (retrieving a file from the index, flag=0).
> -This hook cannot affect the outcome of 'git checkout'.
> +
> +If this hook exits with a non-zero status, 'git checkout' will exit with the
> +same status.
>
> It is also run after 'git clone', unless the --no-checkout (-n) option is
> used. The first parameter given to the hook is the null-ref, the second the
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-14 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-13 19:59 [PATCH] Documentation/githooks: Clarify the behavior of post-checkout hook Magne Land
2018-03-14 0:38 ` Jonathan Nieder
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).