list mirror (unofficial, one of many)
 help / color / Atom feed
From: Ævar Arnfjörð Bjarmason  <>
Cc: Junio C Hamano <>,
	Michał Kiedrowicz <>,
	Ævar Arnfjörð Bjarmason  <>
Subject: [PATCH 2/3] configure: detect redundant --with-libpcre & --with-libpcre1
Date: Sun, 11 Mar 2018 13:26:08 +0000
Message-ID: <> (raw)
In-Reply-To: <>

The --with-libpcre option is a synonym for the --with-libpcre1 flag,
but the configure script allowed for redundantly specifying both.

Nothing broke as a result of this, but it's confusing, so let's
disallow it.

Signed-off-by: Ævar Arnfjörð Bjarmason <>
--- | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ b/
index 41ceb2ac81..d1b3b143c4 100644
--- a/
+++ b/
@@ -280,6 +280,10 @@ AS_HELP_STRING([--with-libpcre],[synonym for --with-libpcre1]),
 AS_HELP_STRING([--with-libpcre1],[support Perl-compatible regexes via libpcre1 (default is NO)])
 AS_HELP_STRING([],           [ARG can be also prefix for libpcre library and headers]),
+    if test -n "$USE_LIBPCRE1"; then
+        AC_MSG_ERROR([Only supply one of --with-libpcre or its synonym --with-libpcre1!])
+    fi
     if test "$withval" = "no"; then
     elif test "$withval" = "yes"; then

  parent reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11 13:26 [PATCH 0/3] Switch the default PCRE from v1 to v2 + configure fixes Ævar Arnfjörð Bjarmason
2018-03-11 13:26 ` [PATCH 1/3] configure: fix a regression in PCRE v1 detection Ævar Arnfjörð Bjarmason
2018-03-11 13:26 ` Ævar Arnfjörð Bjarmason [this message]
2018-03-11 13:26 ` [PATCH 3/3] Makefile: make USE_LIBPCRE=YesPlease mean v2, not v1 Ævar Arnfjörð Bjarmason
2018-03-14 22:41 ` [PATCH 0/3] Switch the default PCRE from v1 to v2 + configure fixes Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone public-inbox