list mirror (unofficial, one of many)
 help / color / Atom feed
From: Ævar Arnfjörð Bjarmason  <>
Cc: Junio C Hamano <>,
	Michał Kiedrowicz <>,
	Ævar Arnfjörð Bjarmason  <>
Subject: [PATCH 1/3] configure: fix a regression in PCRE v1 detection
Date: Sun, 11 Mar 2018 13:26:07 +0000
Message-ID: <> (raw)
In-Reply-To: <>

Change the check for PCRE v1 to disable the --with-libpcre1 option if
the pcre_version() function can't be found in the pcre library. I
unintentionally changed this in my 94da9193a6 ("grep: add support for
PCRE v2", 2017-06-01) while renaming moving some variables.

The intent of this check ever since it was added in
a119f91e57 ("configure: Check for libpcre", 2011-05-09) is to
second-guess the user and turn off an explicitly provided
--with-libpcre if the library can't be found.

I don't think that behavior makes any sense, we shouldn't be
second-guessing the user with an auto-detection, but changing that
needs a bigger refactoring of this script, and only has marginal
benefits. So let's fix it to work as it was intended to work again.

Signed-off-by: Ævar Arnfjörð Bjarmason <>
--- | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ b/
index 7f8415140f..41ceb2ac81 100644
--- a/
+++ b/
@@ -549,8 +549,8 @@ if test -n "$USE_LIBPCRE1"; then
 AC_CHECK_LIB([pcre], [pcre_version],

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-11 13:26 [PATCH 0/3] Switch the default PCRE from v1 to v2 + configure fixes Ævar Arnfjörð Bjarmason
2018-03-11 13:26 ` Ævar Arnfjörð Bjarmason [this message]
2018-03-11 13:26 ` [PATCH 2/3] configure: detect redundant --with-libpcre & --with-libpcre1 Ævar Arnfjörð Bjarmason
2018-03-11 13:26 ` [PATCH 3/3] Makefile: make USE_LIBPCRE=YesPlease mean v2, not v1 Ævar Arnfjörð Bjarmason
2018-03-14 22:41 ` [PATCH 0/3] Switch the default PCRE from v1 to v2 + configure fixes Junio C Hamano

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone public-inbox