From: Jonathan Nieder <jrnieder@gmail.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: public git mailing list <git@vger.kernel.org>,
"Carsey, Jaben" <jaben.carsey@intel.com>,
git-for-windows@googlegroups.com
Subject: Re: recent glob expansion breakage on Windows?
Date: Thu, 8 Mar 2018 14:03:56 -0800 [thread overview]
Message-ID: <20180308220356.GA171451@aiede.svl.corp.google.com> (raw)
In-Reply-To: <e0ba9fb9-056e-4979-415b-f8eca47e2490@redhat.com>
+git-for-windows
Hi,
Laszlo Ersek wrote:
> Jaben reports that git-send-email is suddenly failing to expand the
> "*.patch" glob for him, at the Windows CMD prompt:
>
> ---------
> E:\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-cc=cc --suppress-cc=sob --dry-run *.patch
>
> No patch files specified!
> ---------
>
> Whereas, moving the same patch files to another subdir, and then passing
> the subdir to git-send-email, works fine.
>
> I seem to have found some $^O based perl code in the git tree that
> expands the glob manually (in place of the shell) on Windows -- however,
> that code looks ancient ^W very stable, and doesn't seem to explain the
> sudden breakage.
>
> Is it possible that a separate perl update on Jaben's Windows box is
> causing this? Or does the breakage look consistent with a recent git change?
>
> Has anyone else reported something similar recently?
This reminds me of https://github.com/git-for-windows/git/issues/339.
There, Johannes Schindelin writes (about a different command):
| This is expected because neither PowerShell nor cmd.exe nor git.exe
| expand wildcards. Those examples you found were written with a shell
| in mind, and the shell expands wildcards (hence Git does not think
| it needs to).
That may or may not also apply to send-email. In what version did it
work?
Thanks,
Jonathan
> Thanks (and sorry about the noise; this list might not be the best place
> to ask)!
> Laszlo
next prev parent reply other threads:[~2018-03-08 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 21:02 recent glob expansion breakage on Windows? Laszlo Ersek
2018-03-08 22:03 ` Jonathan Nieder [this message]
2018-03-09 9:41 ` Laszlo Ersek
2018-03-13 23:12 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308220356.GA171451@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=git-for-windows@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=jaben.carsey@intel.com \
--cc=lersek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).