* git-gui: CTRL/CMD + numpad ENTER does not invoke same command as "regular" ENTER
@ 2018-03-01 14:25 Birger Skogeng Pedersen
2018-03-01 14:39 ` [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit Birger Skogeng Pedersen
0 siblings, 1 reply; 5+ messages in thread
From: Birger Skogeng Pedersen @ 2018-03-01 14:25 UTC (permalink / raw)
To: git
In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,
using the numpad ENTER does not invoke the same command.
I propose that both numpad ENTER and "regular" ENTER should invoke the
same command.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit
2018-03-01 14:25 git-gui: CTRL/CMD + numpad ENTER does not invoke same command as "regular" ENTER Birger Skogeng Pedersen
@ 2018-03-01 14:39 ` Birger Skogeng Pedersen
2018-03-01 18:31 ` Eric Sunshine
0 siblings, 1 reply; 5+ messages in thread
From: Birger Skogeng Pedersen @ 2018-03-01 14:39 UTC (permalink / raw)
To: git; +Cc: Birger Skogeng Pedersen
---
git-gui/git-gui.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 91c00e648..6de74ce63 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break}
bind . <$M1B-Key-plus> {show_more_context;break}
bind . <$M1B-Key-KP_Add> {show_more_context;break}
bind . <$M1B-Key-Return> do_commit
+bind . <$M1B-Key-KP_Enter> do_commit
foreach i [list $ui_index $ui_workdir] {
bind $i <Button-1> { toggle_or_diff click %W %x %y; break }
bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
--
2.16.2.268.g7f9c27f2f.dirty
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit
2018-03-01 14:39 ` [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit Birger Skogeng Pedersen
@ 2018-03-01 18:31 ` Eric Sunshine
2018-03-02 9:56 ` Birger Skogeng Pedersen
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sunshine @ 2018-03-01 18:31 UTC (permalink / raw)
To: Birger Skogeng Pedersen; +Cc: Git List
On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen
<birgersp@gmail.com> wrote:
> ---
Please sign-off on your patch. See Documentation/SubmittingPatches.
Also, it would be helpful to write at least a short commit message
justifying the change. The reason you gave in your lead-in email[1]
might be sufficient:
In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,
using the numpad ENTER does not invoke the same command.
(assuming people don't argue that numpad ENTER should be saved for
some other function).
Thanks.
[1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/
> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index 91c00e648..6de74ce63 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break}
> bind . <$M1B-Key-plus> {show_more_context;break}
> bind . <$M1B-Key-KP_Add> {show_more_context;break}
> bind . <$M1B-Key-Return> do_commit
> +bind . <$M1B-Key-KP_Enter> do_commit
> foreach i [list $ui_index $ui_workdir] {
> bind $i <Button-1> { toggle_or_diff click %W %x %y; break }
> bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit
2018-03-01 18:31 ` Eric Sunshine
@ 2018-03-02 9:56 ` Birger Skogeng Pedersen
2018-03-02 10:01 ` [PATCH v2] " Birger Skogeng Pedersen
0 siblings, 1 reply; 5+ messages in thread
From: Birger Skogeng Pedersen @ 2018-03-02 9:56 UTC (permalink / raw)
To: Eric Sunshine; +Cc: Git List
Sorry about that. Version 2 coming right up.
On Thu, Mar 1, 2018 at 7:31 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen
> <birgersp@gmail.com> wrote:
>> ---
>
> Please sign-off on your patch. See Documentation/SubmittingPatches.
>
> Also, it would be helpful to write at least a short commit message
> justifying the change. The reason you gave in your lead-in email[1]
> might be sufficient:
>
> In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,
> using the numpad ENTER does not invoke the same command.
>
> (assuming people don't argue that numpad ENTER should be saved for
> some other function).
>
> Thanks.
>
> [1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/
>
>> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
>> index 91c00e648..6de74ce63 100755
>> --- a/git-gui/git-gui.sh
>> +++ b/git-gui/git-gui.sh
>> @@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break}
>> bind . <$M1B-Key-plus> {show_more_context;break}
>> bind . <$M1B-Key-KP_Add> {show_more_context;break}
>> bind . <$M1B-Key-Return> do_commit
>> +bind . <$M1B-Key-KP_Enter> do_commit
>> foreach i [list $ui_index $ui_workdir] {
>> bind $i <Button-1> { toggle_or_diff click %W %x %y; break }
>> bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] git-gui: bind CTRL/CMD+numpad ENTER to do_commit
2018-03-02 9:56 ` Birger Skogeng Pedersen
@ 2018-03-02 10:01 ` Birger Skogeng Pedersen
0 siblings, 0 replies; 5+ messages in thread
From: Birger Skogeng Pedersen @ 2018-03-02 10:01 UTC (permalink / raw)
To: git; +Cc: Birger Skogeng Pedersen
CTRL/CMD+ENTER is bound to do_commit, but this did not apply for the
(numpad ENTER) key. To enable CTRL/CMD+ENTER and CTRL/CMD+(numpad ENTER)
to yield the same behaviour, CTRL/CMD+(numpad enter) has also been bound
to do_commit.
Signed-off-by: Birger Skogeng Pedersen <birgersp@gmail.com>
---
git-gui/git-gui.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 91c00e648..6de74ce63 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break}
bind . <$M1B-Key-plus> {show_more_context;break}
bind . <$M1B-Key-KP_Add> {show_more_context;break}
bind . <$M1B-Key-Return> do_commit
+bind . <$M1B-Key-KP_Enter> do_commit
foreach i [list $ui_index $ui_workdir] {
bind $i <Button-1> { toggle_or_diff click %W %x %y; break }
bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
--
2.16.2.270.gdc6133cf5
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-02 10:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01 14:25 git-gui: CTRL/CMD + numpad ENTER does not invoke same command as "regular" ENTER Birger Skogeng Pedersen
2018-03-01 14:39 ` [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit Birger Skogeng Pedersen
2018-03-01 18:31 ` Eric Sunshine
2018-03-02 9:56 ` Birger Skogeng Pedersen
2018-03-02 10:01 ` [PATCH v2] " Birger Skogeng Pedersen
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).