From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 880B41F576 for ; Thu, 1 Mar 2018 07:36:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935414AbeCAHgc (ORCPT ); Thu, 1 Mar 2018 02:36:32 -0500 Received: from cloud.peff.net ([104.130.231.41]:42306 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S935251AbeCAHgb (ORCPT ); Thu, 1 Mar 2018 02:36:31 -0500 Received: (qmail 15893 invoked by uid 109); 1 Mar 2018 07:36:30 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 01 Mar 2018 07:36:30 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 12555 invoked by uid 111); 1 Mar 2018 07:37:20 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Thu, 01 Mar 2018 02:37:20 -0500 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 01 Mar 2018 02:36:29 -0500 Date: Thu, 1 Mar 2018 02:36:29 -0500 From: Jeff King To: demerphq Cc: "Randall S. Becker" , Eric Wong , Jonathan Nieder , Git , Joachim Schmitz , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [Problem] test_must_fail makes possibly questionable assumptions about exit_code. Message-ID: <20180301073629.GC31079@sigill.intra.peff.net> References: <005501d3b025$c0057ce0$401076a0$@nexbridge.com> <20180228001616.GJ174036@aiede.svl.corp.google.com> <20180228040718.GA9043@whir> <20180228050034.GA373@sigill.intra.peff.net> <20180228074251.GA11673@dcvr> <20180228074918.GA32127@sigill.intra.peff.net> <000501d3b0a4$29162a80$7b427f80$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Feb 28, 2018 at 05:51:14PM +0100, demerphq wrote: > I would look into putting it into a module and then using the PERL5OPT > environment var to have it loaded automagically in any of your perl > scripts. > > For instance if you put that code into a module called Git/DieTrap.pm > > then you could do: > > PERL5OPT=-MGit::DieTrap > > In your test setup code assuming you have some. Then you don't need to > change any of your scripts just the test runner framework. That's a clever trick. It's not clear to me though if we just want to tweak the programs run in the test scripts in order to get test_must_fail to stop complaining, or if we consider the unusual exit codes from our perl-based Git programs to be an error that should be fixed for real use, too. -Peff