From: Jeff King <peff@peff.net>
To: demerphq <demerphq@gmail.com>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>,
"Eric Wong" <e@80x24.org>, "Jonathan Nieder" <jrnieder@gmail.com>,
Git <git@vger.kernel.org>,
"Joachim Schmitz" <jojo@schmitz-digital.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.
Date: Thu, 1 Mar 2018 02:36:29 -0500 [thread overview]
Message-ID: <20180301073629.GC31079@sigill.intra.peff.net> (raw)
In-Reply-To: <CANgJU+VYkmUhJT=CHQ4HTqoV4gWhr9P4-65BfrY-RWgwJJhEUA@mail.gmail.com>
On Wed, Feb 28, 2018 at 05:51:14PM +0100, demerphq wrote:
> I would look into putting it into a module and then using the PERL5OPT
> environment var to have it loaded automagically in any of your perl
> scripts.
>
> For instance if you put that code into a module called Git/DieTrap.pm
>
> then you could do:
>
> PERL5OPT=-MGit::DieTrap
>
> In your test setup code assuming you have some. Then you don't need to
> change any of your scripts just the test runner framework.
That's a clever trick.
It's not clear to me though if we just want to tweak the programs run in
the test scripts in order to get test_must_fail to stop complaining, or
if we consider the unusual exit codes from our perl-based Git programs
to be an error that should be fixed for real use, too.
-Peff
next prev parent reply other threads:[~2018-03-01 7:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:50 [Problem] test_must_fail makes possibly questionable assumptions about exit_code Randall S. Becker
2018-02-28 0:16 ` Jonathan Nieder
2018-02-28 4:07 ` Eric Wong
2018-02-28 5:00 ` Jeff King
2018-02-28 7:42 ` Eric Wong
2018-02-28 7:49 ` Jeff King
2018-02-28 14:55 ` Randall S. Becker
2018-02-28 16:51 ` demerphq
2018-03-01 7:36 ` Jeff King [this message]
2018-03-01 8:16 ` demerphq
2018-03-01 14:28 ` Randall S. Becker
2018-03-01 15:08 ` Jeff King
2018-03-01 15:30 ` demerphq
2018-02-28 16:22 ` Junio C Hamano
2018-02-28 16:46 ` demerphq
2018-02-28 17:10 ` Randall S. Becker
2018-02-28 17:19 ` demerphq
2018-02-28 17:20 ` demerphq
2018-02-28 17:32 ` Randall S. Becker
2018-02-28 17:44 ` Jonathan Nieder
2018-02-28 18:21 ` Randall S. Becker
2018-02-28 18:51 ` Jonathan Nieder
2018-02-28 20:04 ` Randall S. Becker
2018-02-28 22:02 ` Randall S. Becker
2018-02-28 23:16 ` Jonathan Nieder
2018-03-01 7:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301073629.GC31079@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=demerphq@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=jojo@schmitz-digital.de \
--cc=jrnieder@gmail.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).