From: Jonathan Nieder <jrnieder@gmail.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: 'demerphq' <demerphq@gmail.com>, "'Jeff King'" <peff@peff.net>,
"'Eric Wong'" <e@80x24.org>, 'Git' <git@vger.kernel.org>,
"'Joachim Schmitz'" <jojo@schmitz-digital.de>,
"'Ævar Arnfjörð Bjarmason'" <avarab@gmail.com>
Subject: Re: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.
Date: Wed, 28 Feb 2018 15:16:38 -0800 [thread overview]
Message-ID: <20180228231638.GG251290@aiede.svl.corp.google.com> (raw)
In-Reply-To: <007001d3b0df$e8b9c280$ba2d4780$@nexbridge.com>
Randall S. Becker wrote:
> The original thread below has details of what the original issue was and
> why. It hit three tests specifically on this platform where die was invoked
> (at least on one of them). Perl was invoked under the covers and the
> completion code of 169 propagated back through git to the test framework.
> https://public-inbox.org/git/499fb29f-ca34-8d28-256d-896107c29a3e@kdbg.org/T
> /#m0b30f0857feae2044f38e04dc6b8565b68b7d52b
That is:
test_must_fail git send-email --dump-aliases --to=janice@example.com -1 refs/heads/accounting
Which matches the case described elsewhere in this thread. It's
git-send-email.perl. test_must_fail is doing its job correctly by
diagnosing a real bug in git-send-email.perl, which we're grateful for
you having discovered. :)
Thanks,
Jonathan
next prev parent reply other threads:[~2018-02-28 23:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:50 [Problem] test_must_fail makes possibly questionable assumptions about exit_code Randall S. Becker
2018-02-28 0:16 ` Jonathan Nieder
2018-02-28 4:07 ` Eric Wong
2018-02-28 5:00 ` Jeff King
2018-02-28 7:42 ` Eric Wong
2018-02-28 7:49 ` Jeff King
2018-02-28 14:55 ` Randall S. Becker
2018-02-28 16:51 ` demerphq
2018-03-01 7:36 ` Jeff King
2018-03-01 8:16 ` demerphq
2018-03-01 14:28 ` Randall S. Becker
2018-03-01 15:08 ` Jeff King
2018-03-01 15:30 ` demerphq
2018-02-28 16:22 ` Junio C Hamano
2018-02-28 16:46 ` demerphq
2018-02-28 17:10 ` Randall S. Becker
2018-02-28 17:19 ` demerphq
2018-02-28 17:20 ` demerphq
2018-02-28 17:32 ` Randall S. Becker
2018-02-28 17:44 ` Jonathan Nieder
2018-02-28 18:21 ` Randall S. Becker
2018-02-28 18:51 ` Jonathan Nieder
2018-02-28 20:04 ` Randall S. Becker
2018-02-28 22:02 ` Randall S. Becker
2018-02-28 23:16 ` Jonathan Nieder [this message]
2018-03-01 7:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228231638.GG251290@aiede.svl.corp.google.com \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=demerphq@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=jojo@schmitz-digital.de \
--cc=peff@peff.net \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).