From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 77D661FAE2 for ; Wed, 28 Feb 2018 05:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750775AbeB1FAh (ORCPT ); Wed, 28 Feb 2018 00:00:37 -0500 Received: from cloud.peff.net ([104.130.231.41]:40186 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750756AbeB1FAg (ORCPT ); Wed, 28 Feb 2018 00:00:36 -0500 Received: (qmail 31962 invoked by uid 109); 28 Feb 2018 05:00:36 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Wed, 28 Feb 2018 05:00:36 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 31567 invoked by uid 111); 28 Feb 2018 05:01:25 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Wed, 28 Feb 2018 00:01:25 -0500 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Wed, 28 Feb 2018 00:00:34 -0500 Date: Wed, 28 Feb 2018 00:00:34 -0500 From: Jeff King To: Eric Wong Cc: Jonathan Nieder , "Randall S. Becker" , git@vger.kernel.org, 'Joachim Schmitz' , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [Problem] test_must_fail makes possibly questionable assumptions about exit_code. Message-ID: <20180228050034.GA373@sigill.intra.peff.net> References: <005501d3b025$c0057ce0$401076a0$@nexbridge.com> <20180228001616.GJ174036@aiede.svl.corp.google.com> <20180228040718.GA9043@whir> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180228040718.GA9043@whir> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Feb 28, 2018 at 04:07:18AM +0000, Eric Wong wrote: > > In the rest of git, die() makes a command exit with status 128. The > > trouble here is that our code in Perl is assuming the same meaning for > > die() but using perl's die builtin instead. That suggests a few > > options: > > > > a) We could override the meaning of die() in Git.pm. This feels > > ugly but if it works, it would be a very small patch. > > Unlikely to work since I think we use eval {} to trap exceptions > from die. > > > b) We could forbid use of die() and use some git_die() instead (but > > with a better name) for our own error handling. > > Call sites may be dual-use: "die" can either be caught by an > eval or used to show an error message to the user. > > > c) We could have a special different exit code convention for > > commands written in Perl. And then change expectations whenever a > > command is rewritten in C. As you might expect, I don't like this > > option. > > I don't like it, either. > > > d) We could wrap each command in an eval {...} block to convert the > > result from die() to exit 128. > > I prefer option d) FWIW, I agree with all of that. You can do (d) without an enclosing eval block by just hooking the __DIE__ handler, like: $SIG{__DIE__} = sub { print STDERR "fatal: @_\n"; exit 128; }; -Peff