From: Jeff King <peff@peff.net>
To: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] two small grep patches
Date: Fri, 23 Feb 2018 13:01:09 -0500 [thread overview]
Message-ID: <20180223180109.GA5208@sigill.intra.peff.net> (raw)
In-Reply-To: <20180223144757.31875-1-rv@rasmusvillemoes.dk>
On Fri, Feb 23, 2018 at 03:47:55PM +0100, Rasmus Villemoes wrote:
> Changes in v2:
>
> - Drop patch 3 with dubious gain/complexity ratio
> - Add comments regarding ownership of grep_source
>
> I was a little torn between copy-pasting the comment or just saying
> "see above" in the second case. I think a memset would be confusing,
> at least unless one extends the comment to explain why one then does
> the memset despite the first half of the comment.
This looks good to me. Thanks for following up.
-Peff
prev parent reply other threads:[~2018-02-23 18:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 21:56 [PATCH 0/3] a few grep patches Rasmus Villemoes
2018-02-15 21:56 ` [PATCH 1/3] grep: move grep_source_init outside critical section Rasmus Villemoes
2018-02-15 22:17 ` Jeff King
2018-02-16 19:24 ` Junio C Hamano
2018-02-15 21:56 ` [PATCH 2/3] grep: simplify grep_oid and grep_file Rasmus Villemoes
2018-02-15 21:56 ` [PATCH 3/3] grep: avoid one strdup() per file Rasmus Villemoes
2018-02-15 22:18 ` Jeff King
2018-02-15 22:02 ` [PATCH 0/3] a few grep patches Brandon Williams
2018-02-23 14:47 ` [PATCH v2 0/2] two small " Rasmus Villemoes
2018-02-23 14:47 ` [PATCH v2 1/2] grep: move grep_source_init outside critical section Rasmus Villemoes
2018-02-23 14:47 ` [PATCH v2 2/2] grep: simplify grep_oid and grep_file Rasmus Villemoes
2018-02-23 18:01 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223180109.GA5208@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=rv@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).