From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: Derrick Stolee <dstolee@microsoft.com>, git@vger.kernel.org
Subject: Re: [PATCH] commit: drop uses of get_cached_commit_buffer()
Date: Wed, 21 Feb 2018 18:34:33 -0500 [thread overview]
Message-ID: <20180221233433.GA29992@sigill.intra.peff.net> (raw)
In-Reply-To: <07690508-e6c6-5b3b-6c03-5ad83c9c3501@gmail.com>
On Wed, Feb 21, 2018 at 02:19:17PM -0500, Derrick Stolee wrote:
> > These behaviors are undocumented, untested, and unlikely to be
> > expected by users or other software attempting to parse this output.
> >
> > Helped-by: Jeff King <peff@peff.net>
> > Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
>
> This would be a good time to allow multiple authors, or to just change the
> author, since this is exactly the diff you (Peff) provided in an earlier
> email. The commit message hopefully summarizes our discussion, but I welcome
> edits.
The point is moot if we take the revision I just sent (though in
retrospect I really ought to have put in a Reported-by: for you there).
But some communities are settling on Co-authored-by as a trailer for
this case. And GitHub has started parsing and showing that along with
author information:
https://github.com/blog/2496-commit-together-with-co-authors
-Peff
next prev parent reply other threads:[~2018-02-21 23:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 22:12 Question about get_cached_commit_buffer() Derrick Stolee
2018-02-20 22:57 ` Jeff King
2018-02-21 14:13 ` Derrick Stolee
2018-02-21 18:48 ` Jeff King
2018-02-21 18:52 ` Jeff King
2018-02-21 19:17 ` [PATCH] commit: drop uses of get_cached_commit_buffer() Derrick Stolee
2018-02-21 19:19 ` Derrick Stolee
2018-02-21 23:34 ` Jeff King [this message]
2018-02-21 23:13 ` Jeff King
2018-02-21 23:22 ` Stefan Beller
2018-02-21 23:29 ` Jeff King
2018-02-22 1:52 ` Derrick Stolee
2018-02-21 22:22 ` Question about get_cached_commit_buffer() Junio C Hamano
2018-02-21 22:50 ` Jeff King
2018-02-21 23:03 ` Junio C Hamano
2018-02-21 23:27 ` [PATCH] revision: drop --show-all option Jeff King
2018-02-21 23:45 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221233433.GA29992@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).