git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: marmot1123 <marmot.motoki@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix misconversion of gitsubmodule.txt
Date: Tue, 20 Feb 2018 11:30:36 +0000	[thread overview]
Message-ID: <20180220113036.GG6619@genre.crustytoothpaste.net> (raw)
In-Reply-To: <01020161b2696296-9d580cc6-c21f-4fa2-a876-7d77d36cb44a-000000@eu-west-1.amazonses.com>

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

On Tue, Feb 20, 2018 at 08:51:46AM +0000, marmot1123 wrote:
> In the 2nd and 4th paragraph of DESCRIPTION, there ware misconversions `submodule’s`.
> It seems non-ASCII apostrophes, so I rewrite ASCII apostrophes.

While I agree consistency is good, does this have any effect on the
output?  I think AsciiDoc (and Asciidoctor) produce the non-ASCII
format for output, so this should be a no-op for all known output
formats.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 867 bytes --]

  parent reply	other threads:[~2018-02-20 11:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20  8:51 [PATCH] Fix misconversion of gitsubmodule.txt marmot1123
2018-02-20 10:02 ` Eric Sunshine
2018-02-20 11:30 ` brian m. carlson [this message]
2018-02-20 11:48 ` [PATCH v2] " marmot1123
2018-02-20 18:50   ` Stefan Beller
2018-02-20 19:36     ` Kaartic Sivaraam
2018-02-20 19:44       ` Stefan Beller
2018-02-20 19:38   ` Todd Zullinger
2018-02-20 20:12     ` Junio C Hamano
2018-02-22  8:52   ` [PATCH v3 1/2] " marmot1123
2018-02-22  8:52     ` [PATCH v3 2/2] Replace non-ASCII apostrophes to ASCII single quotes in gitsubmodules.txt marmot1123
2018-02-22 20:30       ` Junio C Hamano
2018-02-22 18:38     ` [PATCH v3 1/2] Fix misconversion of gitsubmodule.txt Stefan Beller
2018-02-22 20:20       ` Junio C Hamano
2018-02-22 20:36         ` Stefan Beller
2018-02-22 20:42           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180220113036.GG6619@genre.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=git@vger.kernel.org \
    --cc=marmot.motoki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).