From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.4 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 2D4B01F404 for ; Thu, 15 Feb 2018 05:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751067AbeBOF2n (ORCPT ); Thu, 15 Feb 2018 00:28:43 -0500 Received: from cloud.peff.net ([104.130.231.41]:53346 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750730AbeBOF2m (ORCPT ); Thu, 15 Feb 2018 00:28:42 -0500 Received: (qmail 1003 invoked by uid 109); 15 Feb 2018 05:28:43 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 15 Feb 2018 05:28:43 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 7211 invoked by uid 111); 15 Feb 2018 05:29:27 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Thu, 15 Feb 2018 00:29:27 -0500 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 15 Feb 2018 00:28:40 -0500 Date: Thu, 15 Feb 2018 00:28:40 -0500 From: Jeff King To: Olga Telezhnaya Cc: git@vger.kernel.org Subject: Re: [PATCH v3 06/23] cat-file: split expand_atom() into 2 functions Message-ID: <20180215052840.GF18780@sigill.intra.peff.net> References: <01020161890f4236-47989eb4-c19f-4282-9084-9d4f90c2ebeb-000000@eu-west-1.amazonses.com> <01020161890f433d-ba3260aa-b9e5-47d0-8e80-46ccf9f8c60f-000000@eu-west-1.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <01020161890f433d-ba3260aa-b9e5-47d0-8e80-46ccf9f8c60f-000000@eu-west-1.amazonses.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote: > Split expand_atom() into 2 different functions, > mark_atom_in_object_info() prepares variable for further filling, > (new) expand_atom() creates resulting string. > Need that for further reusing of formatting logic from ref-filter. > Both functions will be step-by-step removed by the end of this patch. Hmm, this is duplicating the list of atoms. One of the reasons for the mark_query flag in the original is to have a single list, so that it can't go out of sync. So I'd hope to see this split go away by the end of the series... -Peff