From: Brandon Williams <bmwill@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Feb 2018, #02; Tue, 13)
Date: Wed, 14 Feb 2018 10:11:49 -0800 [thread overview]
Message-ID: <20180214181149.GB139458@google.com> (raw)
In-Reply-To: <xmqq8tbwpcdv.fsf@gitster-ct.c.googlers.com>
On 02/13, Junio C Hamano wrote:
>
> * bw/c-plus-plus (2018-01-30) 37 commits
> - replace: rename 'new' variables
> - trailer: rename 'template' variables
> - tempfile: rename 'template' variables
> - wrapper: rename 'template' variables
> - environment: rename 'namespace' variables
> - diff: rename 'template' variables
> - environment: rename 'template' variables
> - init-db: rename 'template' variables
> - unpack-trees: rename 'new' variables
> - trailer: rename 'new' variables
> - submodule: rename 'new' variables
> - split-index: rename 'new' variables
> - remote: rename 'new' variables
> - ref-filter: rename 'new' variables
> - read-cache: rename 'new' variables
> - line-log: rename 'new' variables
> - imap-send: rename 'new' variables
> - http: rename 'new' variables
> - entry: rename 'new' variables
> - diffcore-delta: rename 'new' variables
> - diff: rename 'new' variables
> - diff-lib: rename 'new' variable
> - commit: rename 'new' variables
> - combine-diff: rename 'new' variables
> - remote: rename 'new' variables
> - reflog: rename 'new' variables
> - pack-redundant: rename 'new' variables
> - help: rename 'new' variables
> - checkout: rename 'new' variables
> - apply: rename 'new' variables
> - apply: rename 'try' variables
> - diff: rename 'this' variables
> - rev-parse: rename 'this' variable
> - pack-objects: rename 'this' variables
> - blame: rename 'this' variables
> - object: rename function 'typename' to 'type_name'
> - object_info: change member name from 'typename' to 'type_name'
>
> I do not mind refraining from using these keywords in a foreign
> language in our codebase too much, but at the same time, renaming
> must be done a bit more thoughtfully. When the original uses 'new'
> together with and in contrast to 'old', renaming 'new' must be done
> while preserving the pairing (which may involve renaming 'old' as
> well), for example.
>
> Backburnered, i.e. will drop if other topics start to conflict with
> it, but will accept rerolls.
I was under the impression that people didn't care too much about this
(which is a shame but that's an opinion :). If people were more
interested in a change like this then I'd be happy to go back through
and rename the 'old' variables too.
--
Brandon Williams
next prev parent reply other threads:[~2018-02-14 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 1:51 What's cooking in git.git (Feb 2018, #02; Tue, 13) Junio C Hamano
2018-02-14 9:36 ` Duy Nguyen
2018-02-14 17:12 ` Junio C Hamano
2018-02-14 14:10 ` Derrick Stolee
2018-02-14 17:23 ` Junio C Hamano
2018-02-14 17:47 ` Derrick Stolee
2018-02-14 18:11 ` Brandon Williams [this message]
2018-02-14 18:21 ` Stefan Beller
2018-02-14 19:07 ` Elijah Newren
2018-02-14 20:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214181149.GB139458@google.com \
--to=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).