From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Dominic Sacré" <dominic.sacre@gmx.de>,
git@vger.kernel.org, jonathantanmy@google.com
Subject: Re: Regression in memory consumption of git fsck
Date: Wed, 14 Feb 2018 08:55:52 -0500 [thread overview]
Message-ID: <20180214135551.GA27513@sigill.intra.peff.net> (raw)
In-Reply-To: <20180214124828.27845-1-szeder.dev@gmail.com>
On Wed, Feb 14, 2018 at 01:48:28PM +0100, SZEDER Gábor wrote:
> > If I revert that commit (on top of current master) the memory
> > consumption goes down to 2GB again. The change looks relatively harmless
> > to me, so does anyone know what's going on here?
>
> I could reproduce the increased memory usage even for much smaller
> repositories. The patch below seems to fix it for me.
>
>
> -- >8 --
>
> Subject: [PATCH] fsck: plug tree buffer leak
I think this is fixed already in ba3a08ca0e (fsck: fix leak when
traversing trees, 2018-01-20), which is in 'next' (and marked for "will
merge to master in yesterday's "what's cooking").
-Peff
prev parent reply other threads:[~2018-02-14 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 10:22 Regression in memory consumption of git fsck Dominic Sacré
2018-02-14 12:48 ` SZEDER Gábor
2018-02-14 13:55 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214135551.GA27513@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=dominic.sacre@gmx.de \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).