From: Jonathan Tan <jonathantanmy@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, l.s.r@web.de, stolee@gmail.com
Subject: Re: [PATCH v2 0/2] Refactor hash search with fanout table
Date: Tue, 13 Feb 2018 12:15:34 -0800 [thread overview]
Message-ID: <20180213121534.1c7b42109d40a9c41d0e8f0a@google.com> (raw)
In-Reply-To: <xmqqvaf0psrn.fsf@gitster-ct.c.googlers.com>
On Tue, 13 Feb 2018 11:57:16 -0800
Junio C Hamano <gitster@pobox.com> wrote:
> Jonathan Tan <jonathantanmy@google.com> writes:
>
> > Updates from v1:
> > - use uint32_t so that we can operate on packfiles of up to 4G objects
> > (this also means that I had to change the signature of the function)
> > - don't hide types
> >
> > Derrick: you'll need to slightly change your patch to use the new API.
> > As for find_abbrev_len_for_pack(), that's a good idea - I didn't do it
> > in this set but it definitely should be done.
> >
> > Jonathan Tan (2):
> > packfile: remove GIT_DEBUG_LOOKUP log statements
> > packfile: refactor hash search with fanout table
>
> Hmm, is this meant to replace the topic that was merged to 'next'
> last week?
Yes - René pointed out [1] that V1 of my patch series (which you merged
to 'next') does not handle packfiles of more than 2G pack entries, so I
sent out a new version. Yes, this replaces jt/binsearch-with-fanout.
Sorry for not being clearer.
[1] https://public-inbox.org/git/cfbde137-dbac-8796-f49f-2a543303d33a@web.de/
prev parent reply other threads:[~2018-02-13 20:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 22:36 [PATCH 0/2] Refactor hash search with fanout table Jonathan Tan
2018-02-02 22:36 ` [PATCH 1/2] packfile: remove GIT_DEBUG_LOOKUP log statements Jonathan Tan
2018-02-02 22:36 ` [PATCH 2/2] packfile: refactor hash search with fanout table Jonathan Tan
2018-02-09 18:03 ` René Scharfe
2018-02-09 19:50 ` Jonathan Tan
2018-02-02 23:30 ` [PATCH 0/2] Refactor " Junio C Hamano
2018-02-03 2:09 ` Derrick Stolee
2018-02-13 18:39 ` [PATCH v2 " Jonathan Tan
2018-02-13 18:39 ` [PATCH v2 1/2] packfile: remove GIT_DEBUG_LOOKUP log statements Jonathan Tan
2018-02-13 18:39 ` [PATCH v2 2/2] packfile: refactor hash search with fanout table Jonathan Tan
2018-02-13 18:52 ` [PATCH v2 0/2] Refactor " Derrick Stolee
2018-02-13 19:57 ` Junio C Hamano
2018-02-13 20:15 ` Jonathan Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213121534.1c7b42109d40a9c41d0e8f0a@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).