From: Jonathan Tan <jonathantanmy@google.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2] docs/interpret-trailers: fix agreement error
Date: Tue, 13 Feb 2018 10:41:15 -0800 [thread overview]
Message-ID: <20180213104115.073a239b95a1b868809d08bb@google.com> (raw)
In-Reply-To: <20180213022352.23742-1-sandals@crustytoothpaste.net>
On Tue, 13 Feb 2018 02:23:52 +0000
"brian m. carlson" <sandals@crustytoothpaste.net> wrote:
> In the description of git interpret-trailers, we describe "a group…of
> lines" that have certain characteristics. Ensure both options
> describing this group use a singular verb for parallelism.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> Documentation/git-interpret-trailers.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-interpret-trailers.txt b/Documentation/git-interpret-trailers.txt
> index 9dd19a1dd9..ff446f15f7 100644
> --- a/Documentation/git-interpret-trailers.txt
> +++ b/Documentation/git-interpret-trailers.txt
> @@ -51,7 +51,7 @@ with only spaces at the end of the commit message part, one blank line
> will be added before the new trailer.
>
> Existing trailers are extracted from the input message by looking for
> -a group of one or more lines that (i) are all trailers, or (ii) contains at
> +a group of one or more lines that (i) is all trailers, or (ii) contains at
> least one Git-generated or user-configured trailer and consists of at
> least 25% trailers.
> The group must be preceded by one or more empty (or whitespace-only) lines.
This looks good to me, thanks.
prev parent reply other threads:[~2018-02-13 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 2:56 [PATCH] docs/interpret-trailers: fix agreement error brian m. carlson
2018-02-08 18:13 ` Jonathan Tan
2018-02-08 20:29 ` Junio C Hamano
2018-02-10 16:57 ` brian m. carlson
2018-02-13 2:23 ` [PATCH v2] " brian m. carlson
2018-02-13 18:41 ` Jonathan Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213104115.073a239b95a1b868809d08bb@google.com \
--to=jonathantanmy@google.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).