On Thu, Feb 08, 2018 at 12:29:53PM -0800, Junio C Hamano wrote: > Jonathan Tan writes: > > > On Thu, 8 Feb 2018 02:56:14 +0000 > > "brian m. carlson" wrote: > > > >> Existing trailers are extracted from the input message by looking for > >> -a group of one or more lines that (i) are all trailers, or (ii) contains at > >> -least one Git-generated or user-configured trailer and consists of at > >> +a group of one or more lines that (i) are all trailers, or (ii) contain at > >> +least one Git-generated or user-configured trailer and consist of at > >> least 25% trailers. > >> The group must be preceded by one or more empty (or whitespace-only) lines. > >> The group must either be at the end of the message or be the last > > > > Ah, good catch. Maybe "a group of one or more lines that (i) consists of all > > trailers, or (ii) contains ..."? > > Your version reads better perhaps because it talks about "a group" > without placing undue stress on the fact that the member of the > group are usually multiple---I guess it is better over Brian's? I'm happy to make the change to be all singular instead. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204